Skip to content

Move pubsub code into a subpackage #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 3 commits into from
Sep 26, 2016
Merged

Move pubsub code into a subpackage #2419

dhermes merged 3 commits into from
Sep 26, 2016

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 25, 2016

This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3

export PROJECT_DIR="${HOME}/google-cloud-python"
export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357"
cd ${PROJECT_DIR}
git worktree add -b make-pubsub-subpackage ../hotfix official/master
python make_commits.py \
  --git-root "${PROJECT_DIR}/../hotfix" \
  --package pubsub \
  --package-name "Google Cloud Pub/Sub" \
  --readme "${READMES_DIR}/pubsub/README.rst" \
  --extra-requires $'    \'grpcio >= 1.0.0\',\n    \'google-gax >= 0.14.1, < 0.15dev\',\n    \'gapic-google-pubsub-v1 >= 0.9.0, < 0.10dev\',\n    \'grpc-google-pubsub-v1 >= 0.9.0, < 0.10dev\',\n'

NOTE: Since only pubsub and logging had to remove extra deps from GRPC_PACKAGES in setup.py, the 3rd commit is just written the old-fashioned way.

@dhermes dhermes added api: pubsub Issues related to the Pub/Sub API. api: logging Issues related to the Cloud Logging API. labels Sep 25, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2016
This was referenced Sep 25, 2016
Merged
Closed
@dhermes dhermes force-pushed the make-pubsub-subpackage branch from df84621 to 6ed1a94 Compare September 26, 2016 16:32
@tseaver
Copy link
Contributor

tseaver commented Sep 26, 2016

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Sep 26, 2016

Not going to merge this, going to merge #2420 and GitHub will magically close this PR.

@dhermes
Moving all pubsub files into subdirectory.
c6558b9 
Done via:

$ mkdir -p pubsub/google/cloud
$ cp google/__init__.py pubsub/google/__init__.py
$ git add pubsub/google/__init__.py
$ cp google/cloud/__init__.py pubsub/google/cloud/__init__.py
$ git add pubsub/google/cloud/__init__.py
$ git mv google/cloud/pubsub pubsub/google/cloud/pubsub
$ git mv unit_tests/pubsub pubsub/unit_tests
@dhermes
Making pubsub subpackage into a proper package.
ddf2b34 
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-pubsub as a dependency to the umbrella
  package
- Adding the pubsub subdirectory into the list of packages
  for verifying the docs
- Incorporating the pubsub subdirectory into the umbrella
  coverage report
- Adding the pubsub only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the pubsub
  tox config
@dhermes
Remove Pub / Sub deps from setup.py.
27380f9
@dhermes dhermes force-pushed the make-pubsub-subpackage branch from 6ed1a94 to 27380f9 Compare September 26, 2016 19:48
@dhermes dhermes merged commit 27380f9 into googleapis:master Sep 26, 2016
@dhermes dhermes deleted the make-pubsub-subpackage branch September 26, 2016 19:50
parthea pushed a commit that referenced this pull request Nov 24, 2025
@vchudnov-g
feat: check Python and dependency versions in generated GAPICs (#2419)
32e15eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tseaver tseaver

@theacodes theacodes

Labels

api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes @tseaver @theacodes @googlebot