Skip to content

Move bigquery code into a subpackage #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 2 commits into from
Sep 26, 2016
Merged

Move bigquery code into a subpackage #2418

dhermes merged 2 commits into from
Sep 26, 2016

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 25, 2016

This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3

export PROJECT_DIR="${HOME}/google-cloud-python"
export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357"
cd ${PROJECT_DIR}
git worktree add -b make-bigquery-subpackage ../hotfix official/master
python make_commits.py \
  --git-root "${PROJECT_DIR}/../hotfix" \
  --package bigquery \
  --package-name "Google BigQuery" \
  --readme "${READMES_DIR}/bigquery/README.rst"

@dhermes dhermes added api: bigquery Issues related to the BigQuery API. packaging labels Sep 25, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2016
@dhermes dhermes mentioned this pull request Sep 25, 2016
Closed
32 tasks
theacodes
theacodes approved these changes Sep 25, 2016
View reviewed changes
bigquery/README.rst Outdated
query.run()

for row in query.rows:
print row

This comment was marked as spam.

Sign in to view

@dhermes dhermes force-pushed the make-bigquery-subpackage branch from 6b7e52e to dec1f3d Compare September 26, 2016 16:34
@dhermes
Copy link
Contributor Author

dhermes commented Sep 26, 2016

Folded the print(...) change into 2nd commit

@tseaver
Copy link
Contributor

tseaver commented Sep 26, 2016

LGTM

@dhermes
Moving all bigquery files into subdirectory.
bcb12eb 
Done via:

$ mkdir -p bigquery/google/cloud
$ cp google/__init__.py bigquery/google/__init__.py
$ git add bigquery/google/__init__.py
$ cp google/cloud/__init__.py bigquery/google/cloud/__init__.py
$ git add bigquery/google/cloud/__init__.py
$ git mv google/cloud/bigquery bigquery/google/cloud/bigquery
$ git mv unit_tests/bigquery bigquery/unit_tests
@dhermes
Making bigquery subpackage into a proper package.
9670183 
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-bigquery as a dependency to the umbrella
  package
- Adding the bigquery subdirectory into the list of packages
  for verifying the docs
- Incorporating the bigquery subdirectory into the umbrella
  coverage report
- Adding the bigquery only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the bigquery
  tox config
@dhermes dhermes force-pushed the make-bigquery-subpackage branch from dec1f3d to 9670183 Compare September 26, 2016 19:44
@dhermes
Copy link
Contributor Author

dhermes commented Sep 26, 2016

As with #2416 and #2417, Pushed to resolve rebase conflict and re-ran script. Won't wait on Travis since a) that could be awhile and b) this will be painful.

@dhermes dhermes merged commit afd0ae4 into googleapis:master Sep 26, 2016
@dhermes dhermes deleted the make-bigquery-subpackage branch September 26, 2016 19:45
@dhermes dhermes mentioned this pull request Sep 26, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tseaver tseaver

@theacodes theacodes

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes @tseaver @theacodes @googlebot