Skip to content

Update disabled messages so new pylint passes #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daspecster merged 1 commit into from
Jul 8, 2016
Merged

Update disabled messages so new pylint passes #1967

daspecster merged 1 commit into from
Jul 8, 2016

Conversation

@daspecster
Copy link
Contributor

@daspecster daspecster commented Jul 8, 2016 •
edited
Loading

Probably should discuss?

https://github.com/PyCQA/pylint/blob/master/ChangeLog

The docstring for a function or method should summarize its behavior and document its arguments, return value(s), side effects, exceptions raised, and restrictions on when it can be called (all if applicable). Optional arguments should be indicated. It should be documented whether keyword arguments are part of the interface.

From: https://www.python.org/dev/peps/pep-0257/

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 8, 2016
@daspecster daspecster mentioned this pull request Jul 8, 2016
Merged
@daspecster daspecster changed the title Update disabled messages from new pylint Update disabled messages so new pylint passes Jul 8, 2016
@tseaver
Copy link
Contributor

tseaver commented Jul 8, 2016

LGTM

@tseaver
Copy link
Contributor

tseaver commented Jul 8, 2016

Maybe add a hygeine issue which re-enables those options and fixes the errors?

@daspecster daspecster mentioned this pull request Jul 8, 2016
Closed
@daspecster
Copy link
Contributor Author

daspecster commented Jul 8, 2016

Good idea!

@daspecster daspecster merged commit 56b1a01 into googleapis:master Jul 8, 2016
@tseaver tseaver mentioned this pull request Jul 11, 2016
Merged
This was referenced Aug 3, 2016
Closed
Merged
@daspecster daspecster deleted the update-pylint-settings branch January 24, 2017 15:18
parthea added a commit that referenced this pull request Nov 24, 2025
@renovate-bot @parthea
chore(deps): update all dependencies (#1967)
f50f93e 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tseaver tseaver

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daspecster @tseaver @dhermes @googlebot