Skip to content

Fix pubsub context manager exit error #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daspecster merged 2 commits into from
Jul 4, 2016
Merged

Fix pubsub context manager exit error #1956

daspecster merged 2 commits into from
Jul 4, 2016

Conversation

@daspecster
Copy link
Contributor

@daspecster daspecster commented Jul 4, 2016

Possible fix for #1955, checking the length of self.messages before __exit__.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 4, 2016
@tseaver
Copy link
Contributor

tseaver commented Jul 4, 2016

@daspecster I think a more comprehensive fix would be to check self.messages inside Batch.commit, and exit early. We do document the imperative Batch API, which would still be broken otherwise.

@tseaver
Copy link
Contributor

tseaver commented Jul 4, 2016

LGTM

@daspecster daspecster merged commit eddc4e0 into googleapis:master Jul 4, 2016
@daspecster daspecster deleted the fix-pupsub-exit-context-no-commits branch July 4, 2016 17:48
This was referenced Aug 3, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tseaver tseaver

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daspecster @tseaver @googlebot