Repository navigation
Conversation
Previously, the client only quoted database names in CREATE DATABASE statements if they contained a hyphen. If a database name matched a reserved SQL keyword (such as default or user), or was created without a hyphen under PostgreSQL dialect, the statement was sent without quotes, causing syntax errors from Cloud Spanner. This change: - Unconditionally quotes database names in CREATE DATABASE statements using backticks for GoogleSQL and double quotes for PostgreSQL, aligning with the reference Java and Go clients. - Properly escapes quote and delimiter characters to prevent DDL injection breakouts. - Relies on Cloud Spanner server-side validation for invalid database identifiers rather than maintaining brittle client-side keyword lists.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the database creation logic in both the synchronous and asynchronous Spanner database clients to always quote and escape the database ID based on the database dialect (GoogleSQL or PostgreSQL). Previously, quoting was only applied if the database ID contained a hyphen. The changes ensure that special characters and reserved keywords are properly handled. Corresponding unit tests have been updated and expanded to cover various edge cases, including escaping delimiters and handling reserved keywords for both dialects. I have no further feedback to provide as there are no review comments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the client only quoted database names in CREATE DATABASE statements if they contained a hyphen. If a database name matched a reserved SQL keyword (such as default or user), or was created without a hyphen under PostgreSQL dialect, the statement was sent without quotes, causing syntax errors from Cloud Spanner.
This change: