Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Table class in the Google Cloud Spanner client library to improve identifier quoting and validation. Specifically, it simplifies schema name initialization, updates qualified_table_name to use f-strings, and enhances _quote_identifier to validate input types, check for empty values or control characters, and properly escape quotes and backslashes according to the database dialect (Google Standard SQL vs. PostgreSQL). Additionally, comprehensive unit tests have been added to cover these validation and escaping scenarios. I have no feedback to provide as the changes are well-implemented and thoroughly tested.
Harden table and schema identifier handling against SQL injection when inspecting table schemas. Previously, identifiers were wrapped in backticks or double quotes without escaping embedded delimiter characters, which could allow maliciously crafted table names to break out of identifier boundaries in schema queries. This change: - Escapes backticks and backslashes for GoogleSQL databases. - Escapes double quotes for PostgreSQL databases. - Rejects control characters (such as newlines and null bytes) upfront. - Validates that identifiers are non-empty strings. - Gracefully handles empty schema names for PostgreSQL databases.
olavloite
force-pushed
the
spanner-escape-identifiers
branch
from
November 12, 2026 09:11
4fa10a5 to
cdea5ab
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden table and schema identifier handling against SQL injection when inspecting table schemas.
Previously, identifiers were wrapped in backticks or double quotes without escaping embedded delimiter characters, which could allow maliciously crafted table names to break out of identifier boundaries in schema queries.
This change: