Skip to content

fix(auth): enforce exp/iat claims and propagate leeway in verify_token JWKS branch #19050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phamtoanbaoquan23121985 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(auth): enforce exp/iat claims and propagate leeway in verify_token JWKS branch #19050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc958ac
fix(auth): enforce exp/iat claims and propagate leeway in verify_toke…
bang1850 Nov 12, 2026
a64c28f
test(auth): expand clock-skew offsets to minutes for robust CI execution
bang1850 Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/google-auth/google/oauth2/id_token.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,12 @@ def verify_token(
signing_key.key,
algorithms=[signing_key.algorithm_name],
audience=audience,
leeway=clock_skew_in_seconds,
options={
"verify_signature": True,
"verify_exp": True,
"require": ["exp", "iat"],
},
)
else:
return jwt.decode(
Expand Down
49 changes: 49 additions & 0 deletions packages/google-auth/tests/oauth2/test_id_token.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,55 @@ def test_verify_token_jwk(decode, get_unverified_header, py_jwk_set, _fetch_cert
mock.sentinel.key,
algorithms=["mock-alg"],
audience=None,
leeway=0,
options={
"verify_signature": True,
"verify_exp": True,
"require": ["exp", "iat"],
},
)


@mock.patch("google.oauth2.id_token._fetch_certs", autospec=True)
@mock.patch("jwt.api_jwk.PyJWKSet", autospec=True)
@mock.patch("jwt.get_unverified_header", autospec=True)
@mock.patch("jwt.decode", autospec=True)
def test_verify_token_jwk_clock_skew(
decode, get_unverified_header, py_jwk_set, _fetch_certs
):
certs_url = "abc123"
data = {"keys": [{"alg": "RS256"}]}
_fetch_certs.return_value = data
get_unverified_header.return_value = {"kid": "mock-kid"}

mock_key = mock.MagicMock()
mock_key.key_id = "mock-kid"
mock_key.public_key_use = "sig"
mock_key.key = mock.sentinel.key
mock_key.algorithm_name = "mock-alg"
py_jwk_set.from_dict.return_value.keys = [mock_key]
result = id_token.verify_token(
mock.sentinel.token,
mock.sentinel.request,
certs_url=certs_url,
clock_skew_in_seconds=10,
)
assert result == decode.return_value
py_jwk_set.from_dict.assert_called_once_with(data)
get_unverified_header.assert_called_once_with(mock.sentinel.token)

_fetch_certs.assert_called_once_with(mock.sentinel.request, certs_url)
decode.assert_called_once_with(
mock.sentinel.token,
mock.sentinel.key,
algorithms=["mock-alg"],
audience=None,
leeway=10,
options={
"verify_signature": True,
"verify_exp": True,
"require": ["exp", "iat"],
},
)


Expand Down
Loading
Loading