Repository navigation
Conversation
Historically, the Spanner dialect patched SQLAlchemy's global operator table at module import time to support single-key JSON indexing, routing compilation through an internal fallback method. Now that the dialect implements dedicated compiler visitor methods for JSON indexing, this global monkey-patch and fallback override are no longer used. This change: - Removes the mutation of SQLAlchemy's global operator dictionary at import time, preventing unintended side effects on other database dialects running in the same process. - Removes the obsolete compiler fallback override for JSON expressions. - Adds test coverage to verify that the global operator dictionary remains untouched and that JSON subscripting in filter conditions works as expected.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the SQLAlchemy Spanner dialect to avoid mutating the global SQLAlchemy OPERATORS table. It removes the custom _generate_generic_binary override and instead relies on standard visitor dispatching (visit_json_getitem_op_binary) for JSON indexing. Additionally, new unit and mock server tests have been added to verify JSON binary dispatch, operator table integrity, and JSON filtering behavior. I have no feedback to provide as there are no review comments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historically, the Spanner dialect patched SQLAlchemy's global operator table at module import time to support single-key JSON indexing, routing compilation through an internal fallback method.
Now that the dialect implements dedicated compiler visitor methods for JSON indexing, this global monkey-patch and fallback override are no longer used.
This change: