Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the minimum versions of several key dependencies in setup.py (such as google-cloud-bigquery, google-cloud-bigquery-storage, and geopandas), removes setuptools from direct dependencies, and updates the corresponding constraints file with these new versions and additional transitive dependency constraints. It also applies minor formatting adjustments in biglake.py, gbq_connector.py, and conftest.py. The reviewer recommends ensuring that any obsolete compatibility checks for older versions of these dependencies in pandas_gbq/features.py are removed, as the new minimum versions are now guaranteed.
| # Please also update the minimum version in pandas_gbq/features.py to | ||
| # allow pandas-gbq to detect invalid package versions at runtime. | ||
| "google-cloud-bigquery >=3.20.0,<4.0.0", | ||
| "packaging >=22.0.0", | ||
| "google-cloud-bigquery >=3.43.0,<4.0.0", |
There was a problem hiding this comment.
The minimum versions of several dependencies (such as google-cloud-bigquery to 3.43.0, google-cloud-bigquery-storage to 2.40.0, and geopandas to 1.0.0) have been updated. Please ensure that any obsolete compatibility checks for older versions of these dependencies in pandas_gbq/features.py are removed, as the new minimum versions are now guaranteed by setup.py.
References
- Remove obsolete compatibility checks for older dependency versions when the repository's minimum dependency configuration has been updated to require a newer version.
|
@ohmayr Please could you review? |
|
LGTM! I think we can update the commit message since it's doing more than just updating dependencies. |
Also a few whitespace changes due to running
noxwith all sessions locally.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes several internal issues: b/581963287 (geopandas), b/581962115 & b581961732 (google-cloud-bigquery-storage), b/581963342 (google-api-core), b/581962477 (google-auth) 🦕