Repository navigation
fix(google-cloud-bigtable): clamp mutate_row retry attempt timeouts to remaining operation timeout - #19017
Open
mutianf wants to merge 2 commits into
Open
fix(google-cloud-bigtable): clamp mutate_row retry attempt timeouts to remaining operation timeout#19017mutianf wants to merge 2 commits into
mutianf wants to merge 2 commits into
Conversation
…o remaining operation timeout Use _attempt_timeout_generator(attempt_timeout, operation_timeout) in mutate_row so each retry attempt receives min(attempt_timeout, remaining_operation_timeout) instead of a fixed attempt_timeout.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the mutate_row method in both the async and sync autogenerated Bigtable clients to dynamically retrieve a fresh timeout for each retry attempt using _attempt_timeout_generator. Corresponding unit tests were added to verify this behavior. The review feedback suggests optimizing performance by constructing the MutateRowRequest object once outside of the retry loop, preventing redundant serialization of mutations on every retry attempt.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕