Add tox cover task to travis build. #1875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
|
This isn't necessary. Don't do this. coveralls.io does the job already |
Contributor
Author
|
So this stems from #1870 (comment). |
Contributor
|
I think this should be closed. Even this PR has a coverage check, making it clear it's not needed
|
Contributor
|
@dhermes the point of the PR is that coveralls doesn't test branch coverage, while |
Contributor
Author
|
I see I made this PR too quickly haha, parallel conversation happening #1872 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the
covertask in the travis build process will catch what coveralls.io misses in code branch coverage.