Skip to content

Update references to gcloud #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daspecster wants to merge 1 commit into from
Closed

Update references to gcloud #1845

daspecster wants to merge 1 commit into from

Conversation

@daspecster
Copy link
Contributor

@daspecster daspecster commented Jun 7, 2016

Updates for https://github.com/GoogleCloudPlatform/gcloud-common/issues/142.

Changing references to gcloud-python from gcloud if referring to the python library.

@daspecster daspecster added the docs label Jun 7, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2016
dhermes
dhermes reviewed Jun 8, 2016
View reviewed changes
docs/conf.py Outdated
# -*- coding: utf-8 -*-
#
# gcloud documentation build configuration file, created by
# gcloud-python documentation build configuration file, created by

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Jun 8, 2016

@daspecster I don't see any of these changes as being necessary / helpful.

@jgeewax Is this what you had in mind?

@daspecster daspecster force-pushed the change-usage-of-gcloud branch from 15747de to 2d0dd58 Compare June 8, 2016 14:20
@daspecster
Copy link
Contributor Author

daspecster commented Jun 8, 2016

I think the main changes that were mentioned in the issue were in index.rst.

@dhermes
Copy link
Contributor

dhermes commented Jun 9, 2016

@daspecster There is only one change in index.rst and that change obscures the fact that the user will pip install the PyPI package gcloud (not gcloud-python)

@daspecster
Copy link
Contributor Author

daspecster commented Jun 9, 2016 •
edited
Loading

@dhermes, yeah...should we just close this then?

@dhermes
Copy link
Contributor

dhermes commented Jun 9, 2016

That is my preference

@daspecster
Copy link
Contributor Author

daspecster commented Jun 9, 2016

We can reopen if @jgeewax knows of something we missed.

@daspecster daspecster closed this Jun 9, 2016
@daspecster daspecster deleted the change-usage-of-gcloud branch June 9, 2016 18:46
@daspecster daspecster restored the change-usage-of-gcloud branch June 24, 2016 17:28
@daspecster
Copy link
Contributor Author

daspecster commented Jun 24, 2016 •
edited
Loading

Reopening per @jgeewax https://github.com/GoogleCloudPlatform/gcloud-common/issues/142#issuecomment-228390438

/cc @dhermes

@daspecster daspecster reopened this Jun 24, 2016
@daspecster
Copy link
Contributor Author

daspecster commented Jun 27, 2016

Ping @dhermes
/cc @tseaver

@dhermes
Copy link
Contributor

dhermes commented Jun 29, 2016

@jgeewax said "Yes we need that change.". What is "that change"?

@daspecster
Copy link
Contributor Author

daspecster commented Jun 29, 2016

Yeah, I'm not entirely sure TBH.

@jgeewax
Copy link
Contributor

jgeewax commented Jul 4, 2016

I meant we should re-open, and then double check all the other items in the issue body (https://github.com/GoogleCloudPlatform/gcloud-common/issues/142).

The big obvious one is the glaring "gcloud" on https://googlecloudplatform.github.io/gcloud-python/

@daspecster
Copy link
Contributor Author

daspecster commented Jul 4, 2016

I updated the homepage. Should we change or leave the other updates?

@daspecster daspecster force-pushed the change-usage-of-gcloud branch from 7361e6b to 73f23c0 Compare July 14, 2016 19:48
@daspecster
Copy link
Contributor Author

daspecster commented Jul 26, 2016

Closed by #2026.

@daspecster daspecster closed this Jul 26, 2016
@daspecster daspecster deleted the change-usage-of-gcloud branch January 24, 2017 15:18
parthea pushed a commit that referenced this pull request Oct 21, 2023
@peter-zheng-g @busunkim96
[Asset] Test: fix bucket clean up logic. [(#1845)](GoogleCloudPlatfor…
33a852c 
…m/python-docs-samples#1845)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daspecster @dhermes @jgeewax @googlebot