Skip to content

fix(bigframes): fix field name typos for ai.generate* functions - #17983

Merged
sycai merged 2 commits into
mainfrom
sycai_ai_generate_fix
Aug 4, 2026
Merged

fix(bigframes): fix field name typos for ai.generate* functions#17983
sycai merged 2 commits into
mainfrom
sycai_ai_generate_fix

Conversation

@sycai

@sycai sycai commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #17708 🦕

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a typo in several AI operations where "full_resposne" was corrected to "full_response", and adds corresponding integration tests to verify accessing the "full_response" field using the legacy Ibis compiler. The feedback suggests wrapping the yield statement in the use_ibis_compiler fixture within a try...finally block to ensure that the global SQL compiler setting is properly restored even if a test fails.

Comment thread packages/bigframes/tests/system/small/bigquery/test_ai.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@sycai
sycai marked this pull request as ready for review August 3, 2026 21:01
@sycai
sycai requested review from a team as code owners August 3, 2026 21:01
@sycai
sycai requested review from GarrettWu and tswast and removed request for a team August 3, 2026 21:01
@sycai
sycai requested a review from shuoweil August 4, 2026 16:28
@sycai
sycai merged commit 1b5c48b into main Aug 4, 2026
42 of 43 checks passed
@sycai
sycai deleted the sycai_ai_generate_fix branch August 4, 2026 21:33
shuoweil pushed a commit that referenced this pull request Aug 12, 2026
🤖 I have created a release *beep* *boop*
---


##
[2.48.0](bigframes-v2.47.0...bigframes-v2.48.0)
(2026-08-12)


### Features

* **bigframes:** Transpiler supports more string ops
([#17693](#17693))
([7d2bc21](7d2bc21))


### Bug Fixes

* **bigframes:** fix field name typos for ai.generate* functions
([#17983](#17983))
([1b5c48b](1b5c48b))
* **bigframes:** resolve session-scoped API method logging
([#18076](#18076))
([ace618b](ace618b))
* **bigframes:** update GeminiTextGenerator default model to
gemini-2.5-flash
([#18060](#18060))
([5770ff6](5770ff6))
* bump @angular/compiler, @angular/common, @angular/core,
@angular/forms, @angular/platform-browser, @angular/router and
@angular/compiler-cli in
/packages/bigframes/bigframes/display/table_widget_angular
([#17992](#17992))
([346aaab](346aaab))
* bump fast-uri from 3.1.4 to 3.1.5 in
/packages/bigframes/bigframes/display/table_widget_angular
([#17989](#17989))
([3b3f3f4](3b3f3f4))
* bump hono from 4.12.31 to 4.13.1 in
/packages/bigframes/bigframes/display/table_widget_angular
([#18032](#18032))
([cddf35b](cddf35b))
* bump ip-address and express-rate-limit in
/packages/bigframes/bigframes/display/table_widget_angular
([#17985](#17985))
([02ed656](02ed656))
* bump undici and @angular/build in
/packages/bigframes/bigframes/display/table_widget_angular
([#17986](#17986))
([6938061](6938061))
* bump undici from 7.25.0 to 7.29.0 in /packages/bigframes/tests/js
([#17987](#17987))
([65a3571](65a3571))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
copybara-service Bot pushed a commit to google/bigframes that referenced this pull request Aug 12, 2026
🤖 I have created a release *beep* *boop*
---

##
[2.48.0](googleapis/google-cloud-python@bigframes-v2.47.0...bigframes-v2.48.0)
(2026-08-12)

### Features

* **bigframes:** Transpiler supports more string ops
([#17693](googleapis/google-cloud-python#17693))
([7d2bc21](googleapis/google-cloud-python@7d2bc21))

### Bug Fixes

* **bigframes:** fix field name typos for ai.generate* functions
([#17983](googleapis/google-cloud-python#17983))
([1b5c48b](googleapis/google-cloud-python@1b5c48b))
* **bigframes:** resolve session-scoped API method logging
([#18076](googleapis/google-cloud-python#18076))
([ace618b](googleapis/google-cloud-python@ace618b))
* **bigframes:** update GeminiTextGenerator default model to
gemini-2.5-flash
([#18060](googleapis/google-cloud-python#18060))
([5770ff6](googleapis/google-cloud-python@5770ff6))
* bump @angular/compiler, @angular/common, @angular/core,
@angular/forms, @angular/platform-browser, @angular/router and
@angular/compiler-cli in
/packages/bigframes/bigframes/display/table_widget_angular
([#17992](googleapis/google-cloud-python#17992))
([346aaab](googleapis/google-cloud-python@346aaab))
* bump fast-uri from 3.1.4 to 3.1.5 in
/packages/bigframes/bigframes/display/table_widget_angular
([#17989](googleapis/google-cloud-python#17989))
([3b3f3f4](googleapis/google-cloud-python@3b3f3f4))
* bump hono from 4.12.31 to 4.13.1 in
/packages/bigframes/bigframes/display/table_widget_angular
([#18032](googleapis/google-cloud-python#18032))
([cddf35b](googleapis/google-cloud-python@cddf35b))
* bump ip-address and express-rate-limit in
/packages/bigframes/bigframes/display/table_widget_angular
([#17985](googleapis/google-cloud-python#17985))
([02ed656](googleapis/google-cloud-python@02ed656))
* bump undici and @angular/build in
/packages/bigframes/bigframes/display/table_widget_angular
([#17986](googleapis/google-cloud-python#17986))
([6938061](googleapis/google-cloud-python@6938061))
* bump undici from 7.25.0 to 7.29.0 in /packages/bigframes/tests/js
([#17987](googleapis/google-cloud-python#17987))
([65a3571](googleapis/google-cloud-python@65a3571))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
GitOrigin-RevId: 102c940183ac1cf5670b46c17a47f559926634de
Change-Id: Ia15429511df3ebed77f5b4ad45779f8c6be0316d
hebaalazzeh pushed a commit that referenced this pull request Aug 13, 2026
🤖 I have created a release *beep* *boop*
---


##
[2.48.0](bigframes-v2.47.0...bigframes-v2.48.0)
(2026-08-12)


### Features

* **bigframes:** Transpiler supports more string ops
([#17693](#17693))
([7d2bc21](7d2bc21))


### Bug Fixes

* **bigframes:** fix field name typos for ai.generate* functions
([#17983](#17983))
([1b5c48b](1b5c48b))
* **bigframes:** resolve session-scoped API method logging
([#18076](#18076))
([ace618b](ace618b))
* **bigframes:** update GeminiTextGenerator default model to
gemini-2.5-flash
([#18060](#18060))
([5770ff6](5770ff6))
* bump @angular/compiler, @angular/common, @angular/core,
@angular/forms, @angular/platform-browser, @angular/router and
@angular/compiler-cli in
/packages/bigframes/bigframes/display/table_widget_angular
([#17992](#17992))
([346aaab](346aaab))
* bump fast-uri from 3.1.4 to 3.1.5 in
/packages/bigframes/bigframes/display/table_widget_angular
([#17989](#17989))
([3b3f3f4](3b3f3f4))
* bump hono from 4.12.31 to 4.13.1 in
/packages/bigframes/bigframes/display/table_widget_angular
([#18032](#18032))
([cddf35b](cddf35b))
* bump ip-address and express-rate-limit in
/packages/bigframes/bigframes/display/table_widget_angular
([#17985](#17985))
([02ed656](02ed656))
* bump undici and @angular/build in
/packages/bigframes/bigframes/display/table_widget_angular
([#17986](#17986))
([6938061](6938061))
* bump undici from 7.25.0 to 7.29.0 in /packages/bigframes/tests/js
([#17987](#17987))
([65a3571](65a3571))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants