LGTM

After talking with @tbetbetbe, I'm likely to switch this out to depend on gax-google-pubsub-v1 instead: I will be investigating tomorrow.

Keep in mind that this package depends on 'grpcio>=0.13.1' -- which might be a Python3 problem...

Keep in mind that this package depends on 'grpcio>=0.13.1' -- which might be a Python3 problem...

@jgeewax This PR adds the dependency only to the list for the grpc extra, which will be folded into install_requires once we have a Py3k story for gRPC.

FYI: @anthmgoogle

@tbetbetbe where should I be reporting issues / suggesting changes for gax-google-pubsub-v1?

https://github.com/googleapis/gax-python/issues

On 26 April 2016 at 13:37, Tres Seaver notifications@github.com wrote:

@tbetbetbe https://github.com/tbetbetbe where should I be reporting
issues / suggesting changes for gax-google-pubsub-v1?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1753 (comment)

This email may be confidential or privileged. If you received this
communication by mistake, please don't forward it to anyone else (it may
contain confidential or privileged information), please erase all copies of
it, including all attachments, and please let the sender know it went to
the wrong person. Thanks.