Allow convenient filtering of metric descriptors by type prefix. #1751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimey
added
type: feature request
googlebot
added
the
cla: yes
Contributor
|
This PR looks good to me. |
| PREFIX = 'compute.googleapis.com/' | ||
| descriptors = client.list_metric_descriptors(type_prefix=PREFIX) | ||
|
|
||
| # There are currently 18 types with this prefix, but that may change. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM. @rimey Am I good to merge this for you? |
Contributor
Author
|
@dhermes Yes, it's good to go. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@supriyagarg Could you please also take a look at this?