wip#17437
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces temporary post-processing rules to add the pytest-xdist dependency and run Firestore system tests in parallel using -n auto. It also updates several test fixtures in both synchronous and asynchronous system tests to use "module" scope. The reviewer pointed out that changing the scope of pytest_asyncio fixtures to "module" will cause a ScopeMismatch error unless a matching module- or session-scoped event_loop fixture is defined.
|
|
||
|
|
||
| @pytest_asyncio.fixture | ||
| @pytest_asyncio.fixture(scope="module") |
There was a problem hiding this comment.
Changing the scope of pytest_asyncio fixtures to "module" requires that the underlying event_loop fixture also has a matching or wider scope (e.g., "module" or "session"). By default, pytest-asyncio provides a "function"-scoped event_loop fixture, which causes a ScopeMismatch error during test execution. To prevent this error, define a module- or session-scoped event_loop fixture in this file or in conftest.py if one does not already exist.
1 participant
wip