Skip to content

Allow passing 'description' 'ManagedZone.__init__' #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 1 commit into from
Apr 19, 2016
Merged

Allow passing 'description' 'ManagedZone.__init__' #1729

tseaver merged 1 commit into from
Apr 19, 2016

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 18, 2016 •
edited
Loading

Uses #1728 as a base.

Likewise, allow passing 'description' to 'Client.zone'.

Closes: #1721

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2016
@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: dns Issues related to the Cloud DNS API. labels Apr 18, 2016
@tseaver tseaver mentioned this pull request Apr 18, 2016
Merged
dhermes
dhermes reviewed Apr 18, 2016
View reviewed changes
gcloud/dns/zone.py
}

if self.dns_name is not None:
resource['dnsName'] = self.dns_name

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Allow passing 'description' 'ManagedZone.__init__'.
3e7f10a 
Likewise, to 'Client.zone'.

Closes: #1721.
@dhermes
Copy link
Contributor

dhermes commented Apr 19, 2016

LGTM

@tseaver tseaver merged commit 18a1af4 into googleapis:master Apr 19, 2016
@tseaver tseaver deleted the 1721-pass_description_to_zone_ctor branch April 19, 2016 03:20
@daspecster daspecster mentioned this pull request Apr 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver @dhermes @googlebot