fix(gapic-generator): remove lagging 3.9 refs#16924
Open
chalmerlowe wants to merge 5 commits into
Open
Conversation
This removes the temporary skip for Python 3.9 in the unit test session and removes it from ALL_PYTHON, completing the drop of Python 3.9 support.
This removes the case for Python 3.9 in the unit test section, as we no longer run tests for this version.
chalmerlowe
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes support for Python 3.9 from the CI configuration and the gapic-generator noxfile. Feedback indicates that the dispatch logic in the CI script is missing entries for other supported Python versions (3.11 and 3.12), which could lead to incomplete test coverage. Additionally, it is noted that dropping support for a Python version constitutes a breaking change that should be reflected in the versioning strategy.
chalmerlowe
commented
May 4, 2026
This removes Python 3.9 from the unittest matrix in unittest.yml.
chalmerlowe
added
the
do not merge
chalmerlowe
removed
the
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is in a holding pattern. It will be merged once we have removed the references to 3.9 in the repo (via generation of the GAPIC libraries and via updates to the handwritten libs)
Removes two lagging refs to 3.9 to finalize the migration of the gapic generator codebase to 3.10+ runtime dependencies.
Fixes #internal issue 🦕