Skip to content

Rename 'Topic.test_iam_permissions' -> 'check_iam_permissions.' #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 1 commit into from
Mar 23, 2016
Merged

Rename 'Topic.test_iam_permissions' -> 'check_iam_permissions.' #1652

tseaver merged 1 commit into from
Mar 23, 2016
+14 −14

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 23, 2016

Closes #1648.

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Mar 23, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2016
@dhermes
Copy link
Contributor

dhermes commented Mar 23, 2016

LGTM.

@tmatsuo FYI

@tseaver tseaver merged commit be4c06c into googleapis:master Mar 23, 2016
@tseaver tseaver deleted the 1648-rename-test_iam_permissions-check_iam_permissions branch March 23, 2016 16:38
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea @gcf-owl-bot
chore: set CODEOWNER to @googleapis/python-core-client-libraries (#1652)
745ffa6 
* chore: set CODEOWNER to @googleapis/python-core-client-libraries

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@harkamaljot @gcf-owl-bot
chore: improve error message in _metadata.py (#1652)
d62d652 
* improve error message

* log last error response

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* update secret

* update test case to make sure failure reason is included

* update test

* update secret

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver @dhermes @googlebot