Skip to content

Use status_pb2.Status to parse error messages from Datastore #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
Mar 18, 2016
Merged

Use status_pb2.Status to parse error messages from Datastore #1618

dhermes merged 1 commit into from
Mar 18, 2016

Conversation

@pcostell
Copy link
Contributor

@pcostell pcostell commented Mar 15, 2016

Addresses #1617

Note that status has other information too that likely should get exposed. This is just an example of what the expected response is.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2016
@pcostell pcostell mentioned this pull request Mar 15, 2016
Closed
@dhermes
Copy link
Contributor

dhermes commented Mar 16, 2016

@pcostell Why not merge? Other than adding status_pb2 unnecessarily (since it is in googleapis-common-protos) this looks fine.

@pcostell pcostell changed the title DONOTSUBMIT: Example using Status Use status_pb2.Status to parse error messages from Datastore Mar 16, 2016
@pcostell
Copy link
Contributor Author

pcostell commented Mar 16, 2016

@dhermes - Sure I can submit it (I wasn't sure if we wanted to do more with the error than just grab the message, but I added a todo).

PTAL.

@tseaver
Copy link
Contributor

tseaver commented Mar 16, 2016

The pylint failure looks like it should be addressed by merging the change from #1583 into the datastore-v1beta3 branch.

dhermes
dhermes reviewed Mar 16, 2016
View reviewed changes
gcloud/datastore/connection.py Outdated
if status != '200':
raise make_exception(headers, content, use_json=False)
# TODO(pcostell): There is more information in the error besides
# the message that should be passed on.

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 16, 2016

@pcostell Too much to ask to squash the 4 commits down to 1?

@pcostell pcostell force-pushed the datastore-v1beta3 branch from f5e686a to 5b3b7d5 Compare March 16, 2016 20:11
@pcostell
Copy link
Contributor Author

pcostell commented Mar 16, 2016

No more TODO and squashed.

@dhermes
Copy link
Contributor

dhermes commented Mar 16, 2016

Great. In order to pass the lint environment, the easiest way will be to update scripts/pylintrc_default as in #1583:

 # DEFAULT:  ignored-modules=
+# RATIONALE:  six aliases stuff for compatibility.
+#             google.protobuf fixes up namespace package "late".
+ignored-modules = six, google.protobuf

@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

@pcostell, rebase now and we can get this merged?

@googlebot
Copy link

googlebot commented Mar 18, 2016

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 18, 2016
@pcostell pcostell force-pushed the datastore-v1beta3 branch from 30d3c65 to 3b44173 Compare March 18, 2016 16:54
@googlebot
Copy link

googlebot commented Mar 18, 2016

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 18, 2016
@pcostell
Copy link
Contributor Author

pcostell commented Mar 18, 2016

Rebased and ready for merge.

@coveralls
Copy link

coveralls commented Mar 18, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 3b44173 on pcostell:datastore-v1beta3 into f9e4efc on GoogleCloudPlatform:datastore-v1beta3.

@coveralls
Copy link

coveralls commented Mar 18, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 3b44173 on pcostell:datastore-v1beta3 into f9e4efc on GoogleCloudPlatform:datastore-v1beta3.

dhermes added a commit that referenced this pull request Mar 18, 2016
@dhermes
Merge pull request #1618 from pcostell/datastore-v1beta3
50824dd 
Use status_pb2.Status to parse error messages from Datastore
@dhermes dhermes merged commit 50824dd into googleapis:datastore-v1beta3 Mar 18, 2016
parthea pushed a commit that referenced this pull request Nov 24, 2025
@noahdietz @alexander-fenster
fix: ignore_unknown_fields parsing service config (#1618)
cca6aa4 
* fix: ignore_unknown_fields parsing service config

* oops capital True

* reformat args

Co-authored-by: Alexander Fenster <fenster@google.com>

---------

Co-authored-by: Alexander Fenster <fenster@google.com>
parthea added a commit that referenced this pull request Nov 26, 2025
@parthea @gcf-owl-bot
chore: update templated files (#1618)
d3476ed 
* chore: update templated files

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pcostell @dhermes @tseaver @googlebot @coveralls