Adding system tests for HappyBase Table.cells() and scan(). #1606
Conversation
googlebot
added
the
cla: yes
|
|
||
| # Scan with a row prefix. | ||
| prefix = ROW_KEY2[:-1] | ||
| self.assertEqual(prefix, ROW_KEY3[:-1]) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM except for the extraneous assertions, which made me wonder if I were misreading something. |
|
LMK what you think of my comments. I'd like to get this merged and wrap up the Happybase system tests (AFAIK only one PR left for those targeting Cloud Bigtable backend). |
|
You can merge as it stands, but maybe follow up with an explanation of why you think those assertions might fail. |
|
I don't think they'll fail. The assertions are there as a sanity check, i.e. we meant this to be true with the literals we created, but we want to make extra double sure. |
Adding system tests for HappyBase Table.cells() and scan().
* chore(deps): update all dependencies * revert --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>
3 participants
No description provided.