chore(librarian): add ability to update version files for proto-only libraries#14674
Merged
chore(librarian): add ability to update version files for proto-only libraries#14674
Conversation
parthea
force-pushed
the
add-support-for-proto-only
branch
from
4ffc32a to
30bc7ee
Compare
parthea
force-pushed
the
add-support-for-proto-only
branch
from
30bc7ee to
9795097
Compare
ohmayr
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add ability to update the version number in version files for proto-only libraries, specifically files
setup.pyandpyproject.toml.For proto-only libraries like
google-cloud-audit-log, version information lives insetup.pyrather thangapic_version.py.See the version string here:
google-cloud-python/packages/google-cloud-audit-log/setup.py
Line 23 in 63eea55
For
pyproject.toml, see here:google-cloud-python/packages/googleapis-common-protos/pyproject.toml
Line 21 in 63eea55
Compared with the version string which exists in
gapic_version.pyhere:google-cloud-python/packages/google-cloud-access-approval/google/cloud/accessapproval_v1/gapic_version.py
Line 16 in 63eea55
Note that in
setup.pyandpyproject.toml, the version string isversion = "a.b.c"whereas ingapic_version.pythe version string is__version__ = "a.b.c"