Skip to content

Moving all system test scripts in system_tests/. #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
Feb 19, 2016
Merged

Moving all system test scripts in system_tests/. #1463

dhermes merged 1 commit into from
Feb 19, 2016

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 13, 2016

Also removing system_tests/__init__.py so it is no longer a package and making all imports happen locally (rather than from the root of the project).

Changes originally inspired by emulator script breakages in #1373.

@jonparrott Having to worry about which scripts can see system_tests is somewhat of an argument for moving into gcloud.system_tests (discussion in #1451). Happy to go that route here instead. WDYT?

As-is, the current fix makes pylint angry, so at the very least we should discuss what to do about that.

@dhermes dhermes added api: datastore Issues related to the Datastore API. testing packaging api: pubsub Issues related to the Pub/Sub API. labels Feb 13, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2016
@theacodes
Copy link
Contributor

theacodes commented Feb 13, 2016

Can we still exclude our system tests if they're a sub-package? If not, can we at least make the package private?

@dhermes
Copy link
Contributor Author

dhermes commented Feb 13, 2016

Sure. Excluding them will mean they don't show up in an sdist, but this probably doesn't matter to tox (I think the main library gets pip installed-ed by tox with -e set, which is editable/developer mode)

@theacodes
Copy link
Contributor

theacodes commented Feb 13, 2016

SGTM. Let's try that.

On Fri, Feb 12, 2016, 11:26 PM Danny Hermes notifications@github.com
wrote:

Sure. Excluding them will mean they don't show up in an sdist, but this
probably doesn't matter to tox (I think the main library gets pip
installed-ed by tox with -e set, which is editable/developer mode)

—
Reply to this email directly or view it on GitHub
#1463 (comment)
.

@dhermes
Copy link
Contributor Author

dhermes commented Feb 19, 2016

@jonparrott Had a revelation that I could just move those scripts into the system_tests directory. DERP.

@dhermes dhermes force-pushed the fix-emulator-import branch from bdbe005 to aa5a498 Compare February 19, 2016 03:53
@dhermes dhermes changed the title Adding system_tests to import path in emulator script. Moving all system test scripts in system_tests/. Feb 19, 2016
@dhermes
Moving all system test scripts in system_tests/.
8c1db22 
Also removing system_tests/__init__.py so it is no longer
a package and making all imports happen locally (rather
than from the root of the project).

Changes originally inspired by emulator script breakages in googleapis#1373.
@dhermes dhermes force-pushed the fix-emulator-import branch from aa5a498 to 8c1db22 Compare February 19, 2016 04:16
@theacodes
Copy link
Contributor

theacodes commented Feb 19, 2016

I can't believe I didn't realize that either. LGTM.

dhermes
dhermes reviewed Feb 19, 2016
View reviewed changes
MANIFEST.in
include README.rst
graft gcloud
global-exclude *.pyc
recursive-exclude system_tests *

This comment was marked as spam.

Sign in to view

dhermes added a commit that referenced this pull request Feb 19, 2016
@dhermes
Merge pull request #1463 from dhermes/fix-emulator-import
7f4575e 
Moving all system test scripts in system_tests/.
@dhermes dhermes merged commit 7f4575e into googleapis:master Feb 19, 2016
@dhermes dhermes deleted the fix-emulator-import branch February 19, 2016 17:44
This was referenced Feb 20, 2016
Merged
Merged
parthea added a commit that referenced this pull request Nov 24, 2025
@dizcology @parthea
fix: snippetgen skip REST snippets (#1463)
887b2d5 
* fix: snippetgen skip REST snippets

* upgrade test case to include REST

* refactor transport_type computation

* revert chunks from incorrect branch

* enable REST transport for goldens and update golden files

* update golden files with REST enabled

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@BigTailWolf @lsirac
feat: adding universe domain support for downscroped credentials (#1463)
91d3c65 
* feat: adding universe domain support for downscroped credentials

* fix lint

* address comments

* Update tests/test_downscoped.py

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

---------

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@theacodes theacodes

Labels

api: datastore Issues related to the Datastore API. api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. packaging testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes @theacodes @googlebot