Skip to content

feat: [google-cloud-gke-hub] add k8s_git_version field #14421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohmayr merged 2 commits into from
Sep 15, 2025
Merged

feat: [google-cloud-gke-hub] add k8s_git_version field #14421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f6188c
feat: add `k8s_git_version` field
gcf-owl-bot[bot] Sep 11, 2025
87a84b0
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/google-cloud-gke-hub/google/cloud/gkehub_v1/types/membership.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,10 +315,15 @@ class ResourceOptions(proto.Message):
This option should be set for clusters with Kubernetes
apiserver versions <1.16.
k8s_version (str):
Optional. Major version of the Kubernetes cluster. This is
only used to determine which version to use for the
Optional. Major and minor version of the Kubernetes cluster.
This is only used to determine which version to use for the
CustomResourceDefinition resources,
``apiextensions/v1beta1`` or\ ``apiextensions/v1``.
k8s_git_version (str):
Optional. Git version of the Kubernetes
cluster. This is only used to gate the Connect
Agent migration to svc.id.goog on GDC-SO
1.33.100 patch and above.
"""

connect_version: str = proto.Field(
Expand All @@ -333,6 +338,10 @@ class ResourceOptions(proto.Message):
proto.STRING,
number=3,
)
k8s_git_version: str = proto.Field(
proto.STRING,
number=4,
)


class ResourceManifest(proto.Message):
Expand Down
13 changes: 11 additions & 2 deletions packages/google-cloud-gke-hub/google/cloud/gkehub_v1beta1/types/membership.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,10 +418,15 @@ class ResourceOptions(proto.Message):
This option should be set for clusters with Kubernetes
apiserver versions <1.16.
k8s_version (str):
Optional. Major version of the Kubernetes cluster. This is
only used to determine which version to use for the
Optional. Major and minor version of the Kubernetes cluster.
This is only used to determine which version to use for the
CustomResourceDefinition resources,
``apiextensions/v1beta1`` or\ ``apiextensions/v1``.
k8s_git_version (str):
Optional. Git version of the Kubernetes
cluster. This is only used to gate the Connect
Agent migration to svc.id.goog on GDC-SO
1.33.100 patch and above.
"""

connect_version: str = proto.Field(
Expand All @@ -436,6 +441,10 @@ class ResourceOptions(proto.Message):
proto.STRING,
number=3,
)
k8s_git_version: str = proto.Field(
proto.STRING,
number=4,
)


class ResourceManifest(proto.Message):
Expand Down
2 changes: 2 additions & 0 deletions packages/google-cloud-gke-hub/tests/unit/gapic/gkehub_v1/test_gke_hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8178,6 +8178,7 @@ def test_create_membership_rest_call_success(request_type):
"connect_version": "connect_version_value",
"v1beta1_crd": True,
"k8s_version": "k8s_version_value",
"k8s_git_version": "k8s_git_version_value",
},
},
"google_managed": True,
Expand Down Expand Up @@ -8860,6 +8861,7 @@ def test_update_membership_rest_call_success(request_type):
"connect_version": "connect_version_value",
"v1beta1_crd": True,
"k8s_version": "k8s_version_value",
"k8s_git_version": "k8s_git_version_value",
},
},
"google_managed": True,
Expand Down
2 changes: 2 additions & 0 deletions ...s/google-cloud-gke-hub/tests/unit/gapic/gkehub_v1beta1/test_gke_hub_membership_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6303,6 +6303,7 @@ def test_create_membership_rest_call_success(request_type):
"connect_version": "connect_version_value",
"v1beta1_crd": True,
"k8s_version": "k8s_version_value",
"k8s_git_version": "k8s_git_version_value",
},
},
},
Expand Down Expand Up @@ -6682,6 +6683,7 @@ def test_update_membership_rest_call_success(request_type):
"connect_version": "connect_version_value",
"v1beta1_crd": True,
"k8s_version": "k8s_version_value",
"k8s_git_version": "k8s_git_version_value",
},
},
},
Expand Down
Loading