Skip to content

chore(revert): Revert "chore: [google-cloud-confidentialcomputing] Update gapic-generator-python to 1.26.2"" #14359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ohmayr merged 1 commit into from
Sep 8, 2025
Merged

chore(revert): Revert "chore: [google-cloud-confidentialcomputing] Update gapic-generator-python to 1.26.2"" #14359

ohmayr merged 1 commit into from
Sep 8, 2025

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Sep 4, 2025 •
edited
Loading

Reverts #14356

BEGIN_COMMIT_OVERRIDE
feat: Add new VerifyConfidentialSpace and VerifyConfidentialGke rpcs and relevant fields
fix!: Move AwsPrincipalTagsOptions out from TokenOptions message
docs: Updated comment for method VerifyAttestation, VerifyAttestationRequest and VerifyAttestationResponse in service ConfidentialComputing is changed
docs: A comment for field aws_principal_tags_options in message .google.cloud.confidentialcomputing.v1.TokenOptions is changed
END_COMMIT_OVERRIDE

Wait for discussion in b/421423826

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 4, 2025
@parthea parthea marked this pull request as ready for review September 5, 2025 16:08
@parthea parthea requested a review from a team as a code owner September 5, 2025 16:08
@snippet-bot
Copy link

snippet-bot bot commented Sep 5, 2025

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 5, 2025
@ohmayr ohmayr enabled auto-merge (squash) September 8, 2025 16:29
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2025
@ohmayr ohmayr merged commit cb89cdd into main Sep 8, 2025
24 checks passed
@ohmayr ohmayr deleted the revert-14356-revert-14323-owl-bot-copy-packages-google-cloud-confidentialcomputing branch September 8, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ohmayr ohmayr ohmayr approved these changes

Assignees

@ohmayr ohmayr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea @ohmayr