feat: implement build command to validate generated library#14129

Merged

parthea merged 32 commits into

mainfrom

add-build-command

Jul 24, 2025

parthea commented Jul 22, 2025

Contributor

Fixes googleapis/librarian#450

parthea added 3 commits

July 22, 2025 21:02


          feat: add build command

aa7c65b


          lint


          update comment

8178b9f

ohmayr reviewed

View reviewed changes

.generator/Dockerfile Outdated

ohmayr reviewed

View reviewed changes

.generator/Dockerfile Outdated

ohmayr reviewed

View reviewed changes

.generator/Dockerfile Outdated

ohmayr reviewed

View reviewed changes

.generator/Dockerfile Outdated

ohmayr commented Jul 22, 2025

Contributor

You can add nox to requirements-text.in.

ohmayr changed the title ~~feat: add build command~~ feat: implement build command to validate generated library

parthea self-assigned this

parthea added 4 commits

July 23, 2025 10:26


          Merge branch 'main' of https://github.com/googleapis/google-cloud-python

4653b5b

 into add-build-command


          increase timeout to 2 hours

ea31579


          update test

0e89af2


          update build command to run tests for a specific library

a4e6e73

parthea marked this pull request as ready for review

July 23, 2025 17:46

parthea requested a review from a team

July 23, 2025 17:46

parthea assigned ohmayr and unassigned parthea

parthea added the owlbot:run label

gcf-owl-bot Bot removed the owlbot:run label

ohmayr reviewed

View reviewed changes

.generator/test_cli.py Outdated

ohmayr reviewed

View reviewed changes

cloudbuild.yaml

ohmayr reviewed

View reviewed changes

.generator/cli.py Outdated

ohmayr reviewed

View reviewed changes

.generator/cli.py Outdated

ohmayr reviewed

View reviewed changes

.generator/cli.py Outdated

ohmayr reviewed

View reviewed changes

.generator/cli.py

ohmayr reviewed

View reviewed changes

.generator/cli.py Outdated


          remove return_value

598660e

parthea mentioned this pull request

Reduce the build time for .generator/Dockerfile #14142

Closed


          Add TODO comment to reduce docker build duration

4f5ec1f

parthea added 3 commits

July 23, 2025 21:15


          add type hints

9d129c8


          refactor common code

3f9b48c


          remove capture output

b9b11b0

parthea force-pushed the add-build-command branch from 3776c55 to b9b11b0 Compare

July 23, 2025 21:27

parthea added 12 commits

July 23, 2025 21:32


          refactor

917cda9


          Merge branch 'main' into add-build-command


          create alias for 3.13.5

e3580ca


          fix build

bb6e8d1


          fix build

33207f9


          fix build

a041f2d


          fix build

17fe1c3


          for testing purposes

eb80f09


          fix build

3a1a40f


          Merge branch 'main' into add-build-command

e9914b0


          restore import

f3235e2


          restore import

a2cc75b

ohmayr reviewed

View reviewed changes

.generator/cli.py Outdated

ohmayr reviewed

View reviewed changes

.generator/cli.py Outdated

ohmayr reviewed

View reviewed changes

.generator/test_cli.py

ohmayr previously approved these changes

View reviewed changes


          add type hint

fce74ed

parthea dismissed ohmayr’s stale review via

fce74ed

July 24, 2025 17:08

parthea added 5 commits

July 24, 2025 17:10


          use repo dir

e36ba3f


          add tests for get_library_id

1ea260e


          add tests for _run_individual_session

8bbe2ad


          add tests for _run_nox_sessions

9e6c7de


          run isort/black

1ec6294

ohmayr approved these changes

View reviewed changes

parthea merged commit c3667fe into main

23 checks passed

parthea deleted the add-build-command branch

July 24, 2025 17:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet