Skip to content

docs: [google-cloud-datacatalog] clarify sql variant in comment for v1beta1.LookupEntryRequest.sql_resource #13741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 4 commits into from
Apr 12, 2025
Merged

docs: [google-cloud-datacatalog] clarify sql variant in comment for v1beta1.LookupEntryRequest.sql_resource #13741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d0dde1
docs: A comment for field `sql_resource` in message `.google.cloud.da…
gcf-owl-bot[bot] Apr 8, 2025
f926b25
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 8, 2025
1826e12
docs: clarify sql variant in comment for v1beta1.LookupEntryRequest.s…
gcf-owl-bot[bot] Apr 9, 2025
72aa51b
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/google-cloud-datacatalog/google/cloud/datacatalog_v1/types/datacatalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,7 @@ class LookupEntryRequest(proto.Message):
- ``datacatalog.entry.{PROJECT_ID}.{LOCATION_ID}.{ENTRY_GROUP_ID}.{ENTRY_ID}``

Identifiers (``*_ID``) should comply with the [Lexical
structure in Standard SQL]
structure in GoogleSQL]
(https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical).

This field is a member of `oneof`_ ``target_name``.
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-datacatalog/google/cloud/datacatalog_v1beta1/types/datacatalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ class LookupEntryRequest(proto.Message):
- ``bigquery.dataset.project_id.dataset_id``
- ``datacatalog.entry.project_id.location_id.entry_group_id.entry_id``

``*_id``\ s should satisfy the standard SQL rules for
``*_id``\ s should satisfy the GoogleSQL rules for
identifiers.
https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical.

Expand Down