Skip to content

build: use ubuntu 22.04 for tests#13377

Merged
parthea merged 4 commits into
mainfrom
use-ubuntu-2204
Dec 19, 2024
Merged

build: use ubuntu 22.04 for tests#13377
parthea merged 4 commits into
mainfrom
use-ubuntu-2204

Conversation

@parthea

@parthea parthea commented Dec 19, 2024

Copy link
Copy Markdown
Contributor

This PR resolves the following issue when running Python 3.7 tests :

  Version 3.7 was not found in the local cache
  Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.

@parthea parthea marked this pull request as ready for review December 19, 2024 12:22
@parthea parthea requested a review from a team December 19, 2024 12:22
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 19, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 19, 2024
jobs:
unit:
runs-on: ubuntu-latest
# Use ubuntu-22.04 until Python 3.7 is removed from the test matrix

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a TODO and link to an umbrella issue for this? A quick search suggests the only currently filed issue for the 3.7 deprecation is #11437, but that deals more with messaging the deprecation. We should have an issue for actually removing support when the time comes, and part of that should be removing this Ubuntu specification.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 84387ef

@parthea parthea enabled auto-merge (squash) December 19, 2024 20:56
@parthea parthea merged commit 9b2f079 into main Dec 19, 2024
@parthea parthea deleted the use-ubuntu-2204 branch December 19, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants