Skip to content

feat: [google-cloud-deploy] add Skaffold verbose support to Execution Environment properties #12701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 4 commits into from
May 16, 2024
Merged

feat: [google-cloud-deploy] add Skaffold verbose support to Execution Environment properties #12701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a6d2ce
feat: add Skaffold verbose support to Execution Environment properties
gcf-owl-bot[bot] May 15, 2024
48c5ea2
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 15, 2024
118893a
See https://github.com/googleapis/gapic-generator-python/issues/1887
parthea May 16, 2024
b0e39cd
Merge branch 'main' into owl-bot-copy-packages-google-cloud-deploy
parthea May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/google-cloud-deploy/google/cloud/deploy_v1/types/cloud_deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1651,6 +1651,10 @@ class ExecutionConfig(proto.Message):
Execution. This must be between 10m and 24h in
seconds format. If unspecified, a default
timeout of 1h is used.
verbose (bool):
Optional. If true, additional logging will be
enabled when running builds in this execution
environment.
"""

class ExecutionEnvironmentUsage(proto.Enum):
Expand Down Expand Up @@ -1711,6 +1715,10 @@ class ExecutionEnvironmentUsage(proto.Enum):
number=7,
message=duration_pb2.Duration,
)
verbose: bool = proto.Field(
proto.BOOL,
number=8,
)


class DefaultPool(proto.Message):
Expand Down
3 changes: 3 additions & 0 deletions packages/google-cloud-deploy/tests/unit/gapic/deploy_v1/test_cloud_deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21459,6 +21459,7 @@ def test_create_target_rest(request_type):
"service_account": "service_account_value",
"artifact_storage": "artifact_storage_value",
"execution_timeout": {"seconds": 751, "nanos": 543},
"verbose": True,
}
],
"deploy_parameters": {},
Expand Down Expand Up @@ -21903,6 +21904,7 @@ def test_update_target_rest(request_type):
"service_account": "service_account_value",
"artifact_storage": "artifact_storage_value",
"execution_timeout": {"seconds": 751, "nanos": 543},
"verbose": True,
}
],
"deploy_parameters": {},
Expand Down Expand Up @@ -25405,6 +25407,7 @@ def test_create_release_rest(request_type):
"service_account": "service_account_value",
"artifact_storage": "artifact_storage_value",
"execution_timeout": {},
"verbose": True,
}
],
"deploy_parameters": {},
Expand Down