feat: [google-cloud-private-ca] Add custom subject key identifier field#12447
Merged
Conversation
feat: Add support for fine-grained maximum certificate lifetime controls docs: A comment for field `subject` in message `.google.cloud.security.privateca.v1.CertificateConfig` is changed docs: A comment for method `FetchCaCerts` in service `CertificateAuthorityService` is changed docs: A comment for field `ca_certs` in message `.google.cloud.security.privateca.v1.FetchCaCertsResponse` is changed PiperOrigin-RevId: 615112752 Source-Link: googleapis/googleapis@1793994 Source-Link: googleapis/googleapis-gen@ba61c00 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXByaXZhdGUtY2EvLk93bEJvdC55YW1sIiwiaCI6ImJhNjFjMDA4OWZiNTMwMGYyY2QxZGIwMzM3Njc2NzY4MmRiMTc0NzYifQ==
ohmayr
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: Add custom subject key identifier field
feat: Add support for fine-grained maximum certificate lifetime controls
docs: A comment for field
subjectin message.google.cloud.security.privateca.v1.CertificateConfigis changeddocs: A comment for method
FetchCaCertsin serviceCertificateAuthorityServiceis changeddocs: A comment for field
ca_certsin message.google.cloud.security.privateca.v1.FetchCaCertsResponseis changedEND_COMMIT_OVERRIDE
feat: Add support for fine-grained maximum certificate lifetime controls
docs: A comment for field
subjectin message.google.cloud.security.privateca.v1.CertificateConfigis changeddocs: A comment for method
FetchCaCertsin serviceCertificateAuthorityServiceis changeddocs: A comment for field
ca_certsin message.google.cloud.security.privateca.v1.FetchCaCertsResponseis changedPiperOrigin-RevId: 615112752
Source-Link: googleapis/googleapis@1793994
Source-Link: https://github.com/googleapis/googleapis-gen/commit/ba61c0089fb5300f2cd1db03376767682db17476
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXByaXZhdGUtY2EvLk93bEJvdC55YW1sIiwiaCI6ImJhNjFjMDA4OWZiNTMwMGYyY2QxZGIwMzM3Njc2NzY4MmRiMTc0NzYifQ==