Skip to content

feat: [google-cloud-os-login] added field ImportSshPublicKeyRequest.regions #12168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 4 commits into from
Jan 9, 2024
Merged

feat: [google-cloud-os-login] added field ImportSshPublicKeyRequest.regions #12168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa2b271
feat: add regions field to ImportSshPublicKeyRequest
gcf-owl-bot[bot] Jan 8, 2024
47b7be2
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 8, 2024
151a740
feat: added field `ImportSshPublicKeyRequest.regions`
gcf-owl-bot[bot] Jan 9, 2024
736e66a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/google-cloud-os-login/google/cloud/oslogin/gapic_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
__version__ = "2.12.0" # {x-release-please-version}
__version__ = "0.0.0" # {x-release-please-version}
2 changes: 1 addition & 1 deletion packages/google-cloud-os-login/google/cloud/oslogin_v1/gapic_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
__version__ = "2.12.0" # {x-release-please-version}
__version__ = "0.0.0" # {x-release-please-version}
9 changes: 9 additions & 0 deletions packages/google-cloud-os-login/google/cloud/oslogin_v1/types/oslogin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,11 @@ class ImportSshPublicKeyRequest(proto.Message):
project_id (str):
The project ID of the Google Cloud Platform
project.
regions (MutableSequence[str]):
Optional. The regions to which to assert that
the key was written. If unspecified, defaults to
all regions. Regions are listed at
https://cloud.google.com/about/locations#region.
"""

parent: str = proto.Field(
Expand All @@ -202,6 +207,10 @@ class ImportSshPublicKeyRequest(proto.Message):
proto.STRING,
number=3,
)
regions: MutableSequence[str] = proto.RepeatedField(
proto.STRING,
number=5,
)


class ImportSshPublicKeyResponse(proto.Message):
Expand Down
2 changes: 1 addition & 1 deletion ...le-cloud-os-login/samples/generated_samples/snippet_metadata_google.cloud.oslogin.v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
],
"language": "PYTHON",
"name": "google-cloud-os-login",
"version": "2.12.0"
"version": "0.1.0"
},
"snippets": [
{
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-os-login/scripts/fixup_oslogin_v1_keywords.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class osloginCallTransformer(cst.CSTTransformer):
'delete_ssh_public_key': ('name', ),
'get_login_profile': ('name', 'project_id', 'system_id', ),
'get_ssh_public_key': ('name', ),
'import_ssh_public_key': ('parent', 'ssh_public_key', 'project_id', ),
'import_ssh_public_key': ('parent', 'ssh_public_key', 'project_id', 'regions', ),
'update_ssh_public_key': ('name', 'ssh_public_key', 'update_mask', ),
}

Expand Down
17 changes: 15 additions & 2 deletions packages/google-cloud-os-login/tests/unit/gapic/oslogin_v1/test_os_login_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4039,7 +4039,12 @@ def test_import_ssh_public_key_rest_required_fields(
credentials=ga_credentials.AnonymousCredentials()
).import_ssh_public_key._get_unset_required_fields(jsonified_request)
# Check that path parameters and body parameters are not mixing in.
assert not set(unset_fields) - set(("project_id",))
assert not set(unset_fields) - set(
(
"project_id",
"regions",
)
)
jsonified_request.update(unset_fields)

# verify required fields with non-default values are left alone
Expand Down Expand Up @@ -4094,7 +4099,15 @@ def test_import_ssh_public_key_rest_unset_required_fields():
)

unset_fields = transport.import_ssh_public_key._get_unset_required_fields({})
assert set(unset_fields) == (set(("projectId",)) & set(("parent",)))
assert set(unset_fields) == (
set(
(
"projectId",
"regions",
)
)
& set(("parent",))
)


@pytest.mark.parametrize("null_interceptor", [True, False])
Expand Down