Skip to content

feat: [google-cloud-batch] Add TaskGroup.enable_oslogin to give the Batch job submitter the ability to run runnables as non-root controlled by IAM #12041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 2 commits into from
Nov 21, 2023
Merged

feat: [google-cloud-batch] Add TaskGroup.enable_oslogin to give the Batch job submitter the ability to run runnables as non-root controlled by IAM #12041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0d7a3f
feat: Add TaskGroup.enable_oslogin to give the Batch job submitter th…
gcf-owl-bot[bot] Nov 21, 2023
0f41e59
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/google-cloud-batch/google/cloud/batch/gapic_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
__version__ = "0.17.4" # {x-release-please-version}
__version__ = "0.0.0" # {x-release-please-version}
2 changes: 1 addition & 1 deletion packages/google-cloud-batch/google/cloud/batch_v1/gapic_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
__version__ = "0.17.4" # {x-release-please-version}
__version__ = "0.0.0" # {x-release-please-version}
2 changes: 1 addition & 1 deletion packages/google-cloud-batch/google/cloud/batch_v1alpha/gapic_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
__version__ = "0.17.4" # {x-release-please-version}
__version__ = "0.0.0" # {x-release-please-version}
22 changes: 22 additions & 0 deletions packages/google-cloud-batch/google/cloud/batch_v1alpha/types/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,11 @@ class AllocationPolicy(proto.Message):
reserved.
network (google.cloud.batch_v1alpha.types.AllocationPolicy.NetworkPolicy):
The network policy.

If you define an instance template in the
InstancePolicyOrTemplate field, Batch will use
the network settings in the instance template
instead of this field.
placement (google.cloud.batch_v1alpha.types.AllocationPolicy.PlacementPolicy):
The placement policy.
"""
Expand Down Expand Up @@ -1120,6 +1125,19 @@ class TaskGroup(proto.Message):
When true, Batch will configure SSH to allow
passwordless login between VMs running the Batch
tasks in the same TaskGroup.
enable_oslogin (bool):
Optional. When true, Batch will use the OS Login generated
POSIX account to exeucute the runnables instead of the
default root user.

| To control root or non-root privilege for runnable
execution, the project
| Admin user needs to configure IAM roles according to
https://cloud.google.com/compute/docs/oslogin/set-up-oslogin#configure_users.
Specifically, if a root execution is needed, the
roles/compute.osAdminLogin should be granted to the Batch
job submitter. Otherwise, roles/compute.osLogin should be
granted to the Batch job submitter.
"""

class SchedulingPolicy(proto.Enum):
Expand Down Expand Up @@ -1191,6 +1209,10 @@ class SchedulingPolicy(proto.Enum):
proto.BOOL,
number=12,
)
enable_oslogin: bool = proto.Field(
proto.BOOL,
number=13,
)


class ServiceAccount(proto.Message):
Expand Down
2 changes: 1 addition & 1 deletion .../google-cloud-batch/samples/generated_samples/snippet_metadata_google.cloud.batch.v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
],
"language": "PYTHON",
"name": "google-cloud-batch",
"version": "0.17.4"
"version": "0.1.0"
},
"snippets": [
{
Expand Down
2 changes: 1 addition & 1 deletion ...le-cloud-batch/samples/generated_samples/snippet_metadata_google.cloud.batch.v1alpha.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
],
"language": "PYTHON",
"name": "google-cloud-batch",
"version": "0.17.4"
"version": "0.1.0"
},
"snippets": [
{
Expand Down
1 change: 1 addition & 0 deletions packages/google-cloud-batch/tests/unit/gapic/batch_v1alpha/test_batch_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2687,6 +2687,7 @@ def test_create_job_rest(request_type):
"task_count_per_node": 2022,
"require_hosts_file": True,
"permissive_ssh": True,
"enable_oslogin": True,
}
],
"scheduling_policy": 1,
Expand Down