feat: add the SheetExportAudienceList method to the Data API v1 alpha - #12006
Merged
gcf-merge-on-green[bot] merged 4 commits intoNov 9, 2023
Merged
Conversation
feat: add `creation_quota_tokens_charged`, `row_count`, `error_message` to the `AudienceList` resource
fix: add `optional` annotation to the `page_token` field of the `ListAudienceListsRequest` type
fix: add `optional` annotation to the `offset`, `limit` fields of the `QueryAudienceListRequest` type
fix: add `required` annotation to the `name` field of the `QueryAudienceListRequest` type
fix: add `optional` annotation to the `dimension_name` field of the `AudienceDimension` type
fix: add `optional` annotation to the `property`, `date_ranges`, `funnel`, `funnel_breakdown`, `funnel_visualization_type`, `segments`, `dimension_filter`, `return_property_quota`, `limit` fields of the `RunFunnelReportRequest` type
fix!: change the resource pattern value to `properties/{property}/audienceLists/{audience_list}` for the resource definition `analyticsdata.googleapis.com/AudienceList`
fix!: change the resource pattern value to `properties/{property}` for the resource definition `analyticsadmin.googleapis.com/Property`
PiperOrigin-RevId: 580634757
Source-Link: googleapis/googleapis@a50eda1
Source-Link: googleapis/googleapis-gen@e55c7e4
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWFuYWx5dGljcy1kYXRhLy5Pd2xCb3QueWFtbCIsImgiOiJlNTVjN2U0NzM1MjRlM2RmNDMzMjYwOWFhMjI5NjMxODBlYmExYzAxIn0=
trusted-contributions-gcf
Bot
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
trusted-contributions-gcf
Bot
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
trusted-contributions-gcf
Bot
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
vchudnov-g
reviewed
Nov 9, 2023
| propertyId: str, | ||
| audienceListId: str, | ||
| property: str, | ||
| audience_list: str, |
Contributor
There was a problem hiding this comment.
It seems like this is a braking change, since the name of the parameter changed, and parameters can be named by the caller.
This is an alpha API so having the breaking change is fine, but we should flag it. And we should tweak our process so it gets flagged upstream.
vchudnov-g
added
the
do not merge
Contributor
|
Marking as "do not merge" until we flag the breaking change. |
vchudnov-g
removed
the
do not merge
vchudnov-g
approved these changes
Nov 9, 2023
vchudnov-g
left a comment
vchudnov-g
left a comment
Contributor
There was a problem hiding this comment.
OK, the breaking change is indeed flagged with !, so we can proceed.
trusted-contributions-gcf
Bot
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
vchudnov-g
added
the
automerge
gcf-merge-on-green
Bot
deleted the
owl-bot-copy-packages-google-analytics-data
branch
November 9, 2023 20:32
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: add the SheetExportAudienceList method to the Data API v1 alpha
feat: add
creation_quota_tokens_charged,row_count,error_messageto theAudienceListresourcefix: add
optionalannotation to thepage_tokenfield of theListAudienceListsRequesttypefix: add
optionalannotation to theoffset,limitfields of theQueryAudienceListRequesttypefix: add
requiredannotation to thenamefield of theQueryAudienceListRequesttypefix: add
optionalannotation to thedimension_namefield of theAudienceDimensiontypefix: add
optionalannotation to theproperty,date_ranges,funnel,funnel_breakdown,funnel_visualization_type,segments,dimension_filter,return_property_quota,limitfields of theRunFunnelReportRequesttypefix!: change the resource pattern value to
properties/{property}/audienceLists/{audience_list}for the resource definitionanalyticsdata.googleapis.com/AudienceListfix!: change the resource pattern value to
properties/{property}for the resource definitionanalyticsadmin.googleapis.com/PropertyEND_COMMIT_OVERRIDE
feat: add
creation_quota_tokens_charged,row_count,error_messageto theAudienceListresourcefix: add
optionalannotation to thepage_tokenfield of theListAudienceListsRequesttypefix: add
optionalannotation to theoffset,limitfields of theQueryAudienceListRequesttypefix: add
requiredannotation to thenamefield of theQueryAudienceListRequesttypefix: add
optionalannotation to thedimension_namefield of theAudienceDimensiontypefix: add
optionalannotation to theproperty,date_ranges,funnel,funnel_breakdown,funnel_visualization_type,segments,dimension_filter,return_property_quota,limitfields of theRunFunnelReportRequesttypefix!: change the resource pattern value to
properties/{property}/audienceLists/{audience_list}for the resource definitionanalyticsdata.googleapis.com/AudienceListfix!: change the resource pattern value to
properties/{property}for the resource definitionanalyticsadmin.googleapis.com/PropertyPiperOrigin-RevId: 580634757
Source-Link: googleapis/googleapis@a50eda1
Source-Link: https://github.com/googleapis/googleapis-gen/commit/e55c7e473524e3df4332609aa22963180eba1c01
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWFuYWx5dGljcy1kYXRhLy5Pd2xCb3QueWFtbCIsImgiOiJlNTVjN2U0NzM1MjRlM2RmNDMzMjYwOWFhMjI5NjMxODBlYmExYzAxIn0=