feat: adds script for git migration. #10882
Conversation
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
One relatively minor comment.
But I do think we want the other open comment, deriving ${ARTIFACT_NAME} from the split repo.
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
Looks good. Only issue is about the commented-out gh command. Could you address that before merging?
| $EXIT 1 | ||
| fi | ||
|
|
||
| pushd "${TARGET_REPO}" # To target repo |
There was a problem hiding this comment.
As per offline chat, sounds like we also need to mkdir -p owl-bot-staging/${DISTRIBUTION_NAME} after validation and before creating the PR.
Which means maybe we do the jq extract into ${DISTRIBUTION_NAME} and then set TARGET_PATH="packages/${DISTRIBUTION_NAME}" above?
There was a problem hiding this comment.
As per correction in chat, we'll need to
mkdir -p owl-bot-staging/${DISTRIBUTION_NAME}/${DISTRIBUTION_NAME}
touch owl-bot-staging/${DISTRIBUTION_NAME}/${DISTRIBUTION_NAME}/${DISTRIBUTION_NAME}.txt
git add owl-bot-staging
git commit -m "Trigger owlbot post-processor"
although it's not clear this is sufficient to make the migrated repo pass pre-submits.
There was a problem hiding this comment.
Ok, added owl-bot-staging. But, we should add any necessary fixes, if needed, in follow-up PRs.
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
One non-trivial comment about making the title have a conventional commit format.
2 participants
Script that migrates Git history of a split repo to google-cloud-python.
It copies Git history from source repo (i.e. "split repo") to target repo (i.e.
google-cloud-python). Then, creates a pull request in target repo.