chore(storage): adjust test assertions to new default timeout #10251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
plamut
approved these changes
Jan 30, 2020
Contributor
plamut
left a comment
plamut
left a comment
There was a problem hiding this comment.
Looks good, thanks for taking care of that in the storage lib!
This was referenced Jan 30, 2020
Merged
Merged
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
Merged
[CHANGE ME] Re-generated datastore to pick up changes in the API or client library generator.
#10261
Closed
Merged
This was referenced Jan 30, 2020
This was referenced Jan 31, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 7, 2020
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10250
This PR adjusts a few unit test assertions to the new default timeout in core.
How to test
Actual result (before the fix):
One test failed due to the timeout argument mismatch.
Expected result (after the fix):
All tests pass.