Skip to content

Conversation

@yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Commits in this repo since last synth:
01b7fb9 docs(bigquery): typo fix (#10209)
9ad21f4 feat(core): change default api_request() timeout to non-None (#10219)
8a0e129 fix(automl): fix TablesClient.predict for array and struct (#9991)
7e36fda deprecate(bigquery): deprecate client.dataset() in favor of DatasetReference (#7753)
73eac04 chore(recommender): release 0.2.0 (#10204)
c411e14 feat(recommender): add v1, set release level to beta (#10170)
8e7b7f8 feat(api_core): add retry param into PollingFuture() and it's inheritors (#9923)
0280a94 feat(bigquery): check rows argument type in insert_rows() (#10174)
3c4335d feat(bigquerydatatransfer): add service_account_name option to transfer configs (#10013)
a51da49 test(datacatalog): run unit tests with Python 3.8 (#10014)
c61c238 fix: be permssive about merging an empty struct (#10079)
bda44b3 chore(pubsub): add Python 3.8 unit tests run (via synth)
ae54dc3 feat(bigquery): check json_rows arg type in insert_rows_json() (#10162)
ae7ef87 chore(pubsub): declaratively drop Python 3.4 support (#10168)
d262e9e chores(storage): release 1.25.0 (#10165)
cae942b chore(storage): bump core dependency to 1.2.0 (#10160)
d44e9bf docs(pubsub): tiny spelling mistake fix (#10163)
4886d77 docs(language): fixes typo in Natural Language samples (#10134)
b492bdc fix(bigquerystorage): resume reader connection on EOS internal error (#9994)
7a64502 fix: replace unsafe six.PY3 with PY2 for better future compatibility with Python 4 (#10081)
c71d5f8 refactor(bigquery): to_dataframe uses faster to_arrow + to_pandas when pyarrow is available (#10027)
121394c fix(bigquerystorage): to_dataframe on an arrow stream uses 2x faster to_arrow + to_pandas, internally (#9997)
c05ffe7 chore(core): release core 1.2.0 (#10135)
4b7444a chores(core): bump api-core dependency to 1.16.0 (#10111)
54eac56 docs(spanner): fix Instance.update() docstrings (#10106)
9de4ca1 chore(api_core): release 1.16.0 (#10109)
a0a062d feat(bigtable): support requested_policy_version for Instance IAM (#10001)
9b856cf feat(storage): support optionsRequestedPolicyVersion (#9989)
d897d56 fix(bigquery): write pandas datetime[ns] columns to BigQuery TIMESTAMP columns (#10028)
70fe9b4 fix(logging): update test assertion and core version pins (#10087)
240f381 feat(bigquery): add RowIterator.to_dataframe_iterable method to get pandas DataFrame per page (#10017)
3bb565b fix(storage): fix document of delete blob (#10015)
5ad6287 fix(translate): update test assertion and core version pins (#10098)
561dced fix(dns): update test assertion and core version pins (#10096)
755eb36 fix(resourcemanager): update test assertion and core version pin (#10095)
b144fbf fix(runtimeconfig): update test assertion and core version pins (#10097)
c25d741 feat(api_core): support version 3 policy bindings (#9869)
fafead7 chore(recommender): correct config path in synth file for recommender (#10076)
20cf3b2 chore(cloudbuild): fix broken synth file (#10077)
0384238 fix(bigquery): fix minimum version of dependency (#10016)
be8e6d4 doc(automl): add example for creating a TablesClient for EU in docstring (#9825)
b387134 fix(trace)!: remove span_path resource helper method from v2; modify retry configs; standardize usage of 'optional' and 'required' for args in docstrings; add 2.7 deprecation warning (via synth) (#10075)
16fec16 fix(iot): modify retry and timeout configs; add 2.7 deprecation warning; add 'required' to docstring for required args; add 3.8 unit tests (via synth) (#10069)
efd2e53 chore(bigquery): use 3.6 for blacken session (#10012)
21e4ff3 feat(phishingprotection): undeprecate resource name helper methods, add 2.7 deprecation warning (via synth) (#10048)
e04d1db feat(redis): undeprecate resource name helper methods, add 2.7 deprecation warning (via synth) (#10049)

Log from Synthtool
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/speech/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:19e945954fc960a4bdfee6cb34695898ab21a8cf0bac063ee39b91f00a1faec8
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/speech/artman_speech_v1p1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/cloud_speech.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/google/cloud/speech_v1p1beta1/proto/cloud_speech.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/google/cloud/speech_v1p1beta1/proto.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_transcribe_auto_punctuation_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_transcribe_auto_punctuation_beta.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_quickstart_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_quickstart_beta.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_transcribe_diarization_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_transcribe_diarization_beta.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_transcribe_multilanguage_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_transcribe_multilanguage_beta.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_transcribe_recognition_metadata_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_transcribe_recognition_metadata_beta.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_transcribe_word_level_confidence_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_transcribe_word_level_confidence_beta.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_contexts_classes_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_contexts_classes_beta.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1p1beta1/samples/test/speech_adaptation_beta.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/v1p1beta1/test/speech_adaptation_beta.test.yaml
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.mp3 to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/brooklyn_bridge.mp3
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.raw to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/brooklyn_bridge.raw
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.flac to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/brooklyn_bridge.flac
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/brooklyn_bridge.wav
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/hello.raw to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/hello.raw
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/hello.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/hello.wav
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/multi.flac to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/multi.flac
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/multi.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/multi.wav
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/commercial_mono.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1p1beta1/samples/resources/commercial_mono.wav
synthtool > Writing samples manifest ['gen-manifest', '--env=python', '--bin=python3', '--output=v1p1beta1/test/samples.manifest.yaml', '--chdir={@manifest_dir}/../..', 'v1p1beta1/speech_contexts_classes_beta.py', 'v1p1beta1/speech_transcribe_multilanguage_beta.py', 'v1p1beta1/speech_transcribe_auto_punctuation_beta.py', 'v1p1beta1/speech_adaptation_beta.py', 'v1p1beta1/speech_transcribe_diarization_beta.py', 'v1p1beta1/speech_quickstart_beta.py', 'v1p1beta1/speech_transcribe_recognition_metadata_beta.py', 'v1p1beta1/speech_transcribe_word_level_confidence_beta.py']
synthtool > Running generator for google/cloud/speech/artman_speech_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/cloud_speech.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/google/cloud/speech_v1/proto/cloud_speech.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/google/cloud/speech_v1/proto.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_async_gcs.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_async_gcs.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_async_word_time_offsets_gcs.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_async_word_time_offsets_gcs.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_model_selection.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_model_selection.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_multichannel.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_multichannel.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_model_selection_gcs.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_model_selection_gcs.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_sync_gcs.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_sync_gcs.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_enhanced_model.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_enhanced_model.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_async.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_async.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_multichannel_gcs.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_multichannel_gcs.test.yaml
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/speech/v1/samples/test/speech_transcribe_sync.test.yaml to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/v1/test/speech_transcribe_sync.test.yaml
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.mp3 to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/brooklyn_bridge.mp3
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.raw to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/brooklyn_bridge.raw
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.flac to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/brooklyn_bridge.flac
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/brooklyn_bridge.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/brooklyn_bridge.wav
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/hello.raw to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/hello.raw
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/hello.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/hello.wav
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/multi.flac to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/multi.flac
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/multi.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/multi.wav
synthtool > Download https://storage.googleapis.com/cloud-samples-data/speech/commercial_mono.wav to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/speech-v1/samples/resources/commercial_mono.wav
synthtool > Writing samples manifest ['gen-manifest', '--env=python', '--bin=python3', '--output=v1/test/samples.manifest.yaml', '--chdir={@manifest_dir}/../..', 'v1/speech_transcribe_multichannel.py', 'v1/speech_transcribe_sync_gcs.py', 'v1/speech_transcribe_async_gcs.py', 'v1/speech_transcribe_multichannel_gcs.py', 'v1/speech_transcribe_async.py', 'v1/speech_transcribe_model_selection_gcs.py', 'v1/speech_transcribe_async_word_time_offsets_gcs.py', 'v1/speech_transcribe_enhanced_model.py', 'v1/speech_transcribe_model_selection.py', 'v1/speech_transcribe_sync.py']
synthtool > Replaced 'from google\\.cloud import speech_(.+?)$' in tests/unit/gapic/v1/test_speech_client_v1.py.
synthtool > Replaced 'from google\\.cloud import speech_(.+?)$' in tests/unit/gapic/v1p1beta1/test_speech_client_v1p1beta1.py.
.coveragerc
.flake8
MANIFEST.in
docs/_static/custom.css
docs/_templates/layout.html
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtual environment (virtualenv) using python3.6 in .nox/blacken
pip install black==19.3b0
black docs google tests noxfile.py setup.py samples
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/gapic/speech_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/gapic/transports/speech_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/proto/cloud_speech_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/gapic/speech_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/gapic/speech_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/gapic/transports/speech_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/proto/cloud_speech_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/gapic/speech_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_async.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_async_gcs.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_async_word_time_offsets_gcs.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_enhanced_model.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_model_selection.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_model_selection_gcs.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_multichannel.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_multichannel_gcs.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_sync.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1/speech_transcribe_sync_gcs.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_adaptation_beta.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_contexts_classes_beta.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_quickstart_beta.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_transcribe_auto_punctuation_beta.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_transcribe_diarization_beta.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_transcribe_multilanguage_beta.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_transcribe_word_level_confidence_beta.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/samples/v1p1beta1/speech_transcribe_recognition_metadata_beta.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/tests/unit/gapic/v1/test_speech_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/tests/unit/gapic/v1p1beta1/test_speech_client_v1p1beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1/proto/cloud_speech_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/speech/google/cloud/speech_v1p1beta1/proto/cloud_speech_pb2.py
All done! ✨ 🍰 ✨
35 files reformatted, 17 files left unchanged.
Session blacken was successful.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: speech Issues related to the Speech-to-Text API. label Jan 29, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2020
@busunkim96 busunkim96 changed the title [CHANGE ME] Re-generated speech to pick up changes in the API or client library generator. chore(speech: bump copyright year to 2020, tweak docstring formatting (via synth) Jan 29, 2020
@busunkim96 busunkim96 changed the title chore(speech: bump copyright year to 2020, tweak docstring formatting (via synth) chore(speech): bump copyright year to 2020, tweak docstring formatting (via synth) Jan 29, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2020
@busunkim96 busunkim96 merged commit dad70a7 into master Jan 29, 2020
atulep pushed a commit that referenced this pull request Apr 3, 2023
atulep pushed a commit that referenced this pull request Apr 6, 2023
atulep pushed a commit that referenced this pull request Apr 18, 2023
parthea pushed a commit that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants