Skip to content

test(bigquery): fix snippet test for loading partitioned tables #10195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
plamut wants to merge 1 commit into from
Closed

test(bigquery): fix snippet test for loading partitioned tables #10195

plamut wants to merge 1 commit into from

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Jan 24, 2020

Fixes #10194.

For some reason the number of rows in the public test file us-states-by-date.csv has changed from 50 to 49. This PR adjusts the affected test.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added testing api: bigquery Issues related to the BigQuery API. labels Jan 24, 2020
@plamut plamut requested a review from a team January 24, 2020 10:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 24, 2020
This was referenced Jan 24, 2020
Merged
Closed
Merged
@tswast
Copy link
Contributor

tswast commented Jan 24, 2020

@shollyman Can you look into why this CSV changed and revert it back to the correct file? Note: we should have a rolling backup of files in the storage-samples project that owns this bucket.

@tswast
Copy link
Contributor

tswast commented Jan 24, 2020

I just looked at the bucket. It was indeed modified at January 22, 2020 at 4:20:49 PM UTC-6. Not sure by whom.

$ diff bigquery_us-states_us-states-by-date*
1d0
< name,post_abbr,date
51c50
< Wyoming,WY,1890-07-10
\ No newline at end of file
---
> Wyoming,WY,1890-07-10

Looks like the header line was removed and a new line added at the end. Not sure why.

@tswast
Copy link
Contributor

tswast commented Jan 24, 2020

I've restored the file from backup. Closing this PR.

@tswast tswast closed this Jan 24, 2020
@plamut plamut deleted the fix-partitions-snippet-test branch January 27, 2020 07:35
@plamut plamut mentioned this pull request Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: the test for load partitioned table sample fails

3 participants

@plamut @tswast @googlebot