Skip to content

fix(runtimeconfig): update test assertion and core version pins #10097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
plamut merged 2 commits into from
Jan 10, 2020
Merged

fix(runtimeconfig): update test assertion and core version pins #10097

plamut merged 2 commits into from
Jan 10, 2020

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Jan 10, 2020

Towards #10088.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

plamut added 2 commits January 10, 2020 16:08
@plamut
Adjust request params assertion in test (timeout)
cddb592
@plamut
Update version pin for core dependency
c17058c 
Version bump is needed, as timeouts were introduced to API core.
@plamut plamut added the api: runtimeconfig Issues related to the Cloud Runtime Config API API. label Jan 10, 2020
@plamut plamut requested a review from tswast as a code owner January 10, 2020 16:11
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020
@plamut plamut merged commit b144fbf into googleapis:master Jan 10, 2020
@plamut plamut deleted the fix-tests-runtimeconfig branch January 10, 2020 16:44
This was referenced Jan 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
parthea pushed a commit that referenced this pull request Nov 24, 2025
@plamut
fix(runtimeconfig): update test assertion and core version pins (#10097)
1e27f76 
* Adjust request params assertion in test (timeout)

* Update version pin for core dependency

Version bump is needed, as timeouts were introduced to API core.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

Assignees

No one assigned

Labels

api: runtimeconfig Issues related to the Cloud Runtime Config API API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@plamut @tswast @googlebot