feat(iam): undeprecate resource name helper methods, add 2.7 deprecation warning (via synth) (#10043)

yoshi-automation · busunkim96 · commit feefced0b762 · 2020-01-07T16:18:50.000-08:00
diff --git a/iam/google/cloud/iam_credentials_v1/__init__.py b/iam/google/cloud/iam_credentials_v1/__init__.py
@@ -16,11 +16,22 @@
 
 
 from __future__ import absolute_import
+import sys
+import warnings
 
 from google.cloud.iam_credentials_v1 import types
 from google.cloud.iam_credentials_v1.gapic import iam_credentials_client
 
 
+if sys.version_info[:2] == (2, 7):
+    message = (
+        "A future version of this library will drop support for Python 2.7."
+        "More details about Python 2 support for Google Cloud Client Libraries"
+        "can be found at https://cloud.google.com/python/docs/python2-sunset/"
+    )
+    warnings.warn(message, DeprecationWarning)
+
+
 class IAMCredentialsClient(iam_credentials_client.IAMCredentialsClient):
     __doc__ = iam_credentials_client.IAMCredentialsClient.__doc__
 
diff --git a/iam/google/cloud/iam_credentials_v1/gapic/iam_credentials_client.py b/iam/google/cloud/iam_credentials_v1/gapic/iam_credentials_client.py
@@ -83,12 +83,7 @@ def from_service_account_file(cls, filename, *args, **kwargs):
 
     @classmethod
     def service_account_path(cls, project, service_account):
-        """DEPRECATED. Return a fully-qualified service_account string."""
-        warnings.warn(
-            "Resource name helper functions are deprecated.",
-            PendingDeprecationWarning,
-            stacklevel=1,
-        )
+        """Return a fully-qualified service_account string."""
         return google.api_core.path_template.expand(
             "projects/{project}/serviceAccounts/{service_account}",
             project=project,
diff --git a/iam/synth.metadata b/iam/synth.metadata
