Repository navigation
feat(Gax): add ServiceInterface, LongRunningOperationProviderInterface, and IamProviderInterface - #9754
Open
bshaffer wants to merge 3 commits into
Open
feat(Gax): add ServiceInterface, LongRunningOperationProviderInterface, and IamProviderInterface#9754bshaffer wants to merge 3 commits into
bshaffer wants to merge 3 commits into
Conversation
…e, and IamProviderInterface
| * @return OperationsClient | ||
| * @return DeprecatedOperationsClient|OperationsClient|object | ||
| */ | ||
| private function createOperationsClient(array $options) |
Collaborator
There was a problem hiding this comment.
We have a type annotation but not the actual return type on the function. Any reason why?
Contributor
Author
There was a problem hiding this comment.
Because it's typehinted as object, so I feel like the typehint wouldn't be that useful
Hectorhammett
approved these changes
Nov 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceInterface,LongRunningOperationProviderInterface, andIamProviderInterface.GapicClientTrait::close(): voidand updatecreateOperationsClient()to returnGoogle\LongRunning\Client\OperationsClientin V2 mode.