Renaming all uses of authorize to authenticate #846

dhermes · 2015-09-02T19:55:28Z

This is a mess, so I tried to make it "reproducible".

Fixes #841

Some of the links will be broken unless the language and ~~links~~ paths in gcloud-common are also updated.

To "find" them all I used

git grep -i authori

and then to replace, it was

git grep -l Authorization | xargs sed -i 's/Authorization/Authentication/g'
git grep -l authorization | xargs sed -i 's/authorization/authentication/g'
git grep -l Authorizing | xargs sed -i 's/Authorizing/Authenticating/g'
git grep -l authorizing | xargs sed -i 's/authorizing/authenticating/g'
git grep -l Authorized | xargs sed -i 's/Authorized/Authenticated/g'
git grep -l authorized | xargs sed -i 's/authorized/authenticated/g'
git grep -l authorize | xargs sed -i 's/authorize/authenticate/g'

(There is probably a smarter way to make case-insensitive / case-matching replacements with sed, I just didn't.)

Then this process touched the license so I had to do

git checkout -- COPYING

To check this all "quickly" I used

git diff --color-words

and finally to do the file renames I did

git ls-files | grep -i authori

Instead swapping out for authentication.

stephenplusplus · 2015-09-02T20:28:53Z

Man... words.

Thanks very much for doing this. I think we can take it over from here to get the tests to pass. (@callmehiphop - how about renaming all of our makeAuthenticatedRequest_ to just request or something less wordy?)

callmehiphop · 2015-09-02T20:31:12Z

Sure makeApiRequest_?

stephenplusplus · 2015-09-02T20:34:07Z

Yeah, that's good enough 👍 I think in a separate issue soon, we should once and for all clear up the multiple "makeRequest-ish" methods we have, and just follow a pattern. Will make an issue for that.

dhermes · 2015-09-02T20:40:00Z

Sorry for being a bad OS citizen, I never ran npm test. I recall trying to do it about 12 months ago and having a really bad time (TM).

stephenplusplus · 2015-09-11T18:43:56Z

#861 will take this over. Thanks @dhermes!

dhermes · 2015-09-14T20:48:36Z

Sure thing!

Having the package version there is too much since it updates every time we bump a version. Just the package name is enough.

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/7a1b0b96-8ddb-4836-a1a2-d2f73b7e6ffe/targets - [ ] To automatically regenerate this PR, check this box.

Fixes #1134 🦕 Removes the commit body and relative PR# from the commit message. For example, for this commit: googleapis/synthtool@9763f20 `post-processor-changes.txt` would contain ``` build: enable npm for php/python builds Source-Link: googleapis/synthtool@9763f20 ``` instead of ``` build: enable npm for php/python builds (#1133) * build: enable npm for php/python builds * update comment Source-Link: googleapis/synthtool@9763f20 ``` Source-Link: googleapis/synthtool@e934b93 Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:805e2e389eafefa5ed484c30b83a7a875e6b1c7ee125d812e8b01ecc531c3fac

dhermes added 2 commits September 2, 2015 12:50

Changing all uses of authorization to authentication.

8490e83

Renaming files / paths that use authorization.

e756c05

Instead swapping out for authentication.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2015

stephenplusplus mentioned this pull request Sep 11, 2015

Changing all uses of authorization to authentication. #861

Merged

1 task

stephenplusplus closed this Sep 11, 2015

dhermes deleted the authorize-to-authenticate branch September 14, 2015 20:48

miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025

fix: remove version from protobuf unique root name (#846)

bcbd3cd

Having the package version there is too much since it updates every time we bump a version. Just the package name is enough.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Renaming all uses of authorize to authenticate #846

Renaming all uses of authorize to authenticate #846

Uh oh!

dhermes commented Sep 2, 2015

Uh oh!

stephenplusplus commented Sep 2, 2015

Uh oh!

callmehiphop commented Sep 2, 2015

Uh oh!

stephenplusplus commented Sep 2, 2015

Uh oh!

dhermes commented Sep 2, 2015

Uh oh!

stephenplusplus commented Sep 11, 2015

Uh oh!

dhermes commented Sep 14, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Renaming all uses of authorize to authenticate #846

Renaming all uses of authorize to authenticate #846

Uh oh!

Conversation

dhermes commented Sep 2, 2015

Uh oh!

stephenplusplus commented Sep 2, 2015

Uh oh!

callmehiphop commented Sep 2, 2015

Uh oh!

stephenplusplus commented Sep 2, 2015

Uh oh!

dhermes commented Sep 2, 2015

Uh oh!

stephenplusplus commented Sep 11, 2015

Uh oh!

dhermes commented Sep 14, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants