core: use google-auto-auth#823
Conversation
googlebot
added
the
cla: yes
|
/cc @anthmgoogle (working on the auth libraries) @stephenplusplus : Any reason why we couldn't push the commits upstream into google-auth-library? |
|
google-auth-library is much more complex and lacks documentation. google-auto-auth was just built to simplify it with a more conventional JS approach. I don't think this approach (high-level userland packages that wrap more low-level ones) is anything to worry about. |
|
Cool - if it's something specific like this, maybe we can get it shoved under the google or GCP github organization...? |
|
That's fine with me, though seeing two repos that handle authorization in Node under the same org might be a bit confusing to a user. I'm happy to transfer the ownership of the repo though if you don't think that's a concern. |
|
Eh let's leave it alone for now, and keep it as an idea for discussion On Wed, Aug 26, 2015 at 9:14 AM, Stephen Sawchuk notifications@github.com
|
|
SGTM 👍 |
core: use google-auto-auth
feat: added more Environment RPCs feat: added Versions service feat: added Fulfillment service feat: added TextToSpeechSettings. refactor!: helper agentPath becomes projectAgentPath refactor!: helper intentPath becomes projectAgentIntentPath refactor!: helper entityTypePath becomes projectAgentEntityTypePath PiperOrigin-RevId: 372230736 Fixes #822
* get rid of pegjs * clean up * comments * remove pegjs dependency * error messages * feedback
🤖 I have created a release \*beep\* \*boop\* --- ## [2.4.0](https://www.github.com/googleapis/gax-nodejs/compare/v2.3.1...v2.4.0) (2020-05-21) ### Features * parse path template using regexes ([#823](https://www.github.com/googleapis/gax-nodejs/issues/823)) ([392a392](https://www.github.com/googleapis/gax-nodejs/commit/392a3920df6d78981ac43741f15048c84102b046)) * support non-slash resource in path template ([#833](https://www.github.com/googleapis/gax-nodejs/issues/833)) ([76696fc](https://www.github.com/googleapis/gax-nodejs/commit/76696fc48c8a5e21c3c1cde56822b7a37585e41c)) ### Bug Fixes * new typescript, strict types ([#824](https://www.github.com/googleapis/gax-nodejs/issues/824)) ([90034ce](https://www.github.com/googleapis/gax-nodejs/commit/90034ce6a8c9b635942fedb23345105264979416)) * typescript 3.9.3 compilation ([#831](https://www.github.com/googleapis/gax-nodejs/issues/831)) ([d53e169](https://www.github.com/googleapis/gax-nodejs/commit/d53e16988aa0fa260c91f84e6fc0ceae2fdecc26)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
4 participants
Fixes #822
This incorporates https://github.com/stephenplusplus/google-auto-auth into our library, replacing
google-auth-library(kind of; it's wrapped bygoogle-auto-auth).// cc @ofrobots