Skip to content

fixes #38 return key/prop combined object.#75

Merged
rakyll merged 2 commits intogoogleapis:masterfrom
stephenplusplus:master
Aug 1, 2014
Merged

fixes #38 return key/prop combined object.#75
rakyll merged 2 commits intogoogleapis:masterfrom
stephenplusplus:master

Conversation

@stephenplusplus
Copy link
Contributor

This currently only patches .get & .getAll to return a single array of combined key/property objects. I will move on to query if this seems headed in the right direction 👍

This comment was marked as spam.

@stephenplusplus
Copy link
Contributor Author

Made the same changes with runQuery as well as added tests that were previously missing!

This comment was marked as spam.

This comment was marked as spam.

@rakyll
Copy link
Contributor

rakyll commented Aug 1, 2014

Could you fix the docs in this PR as well?

@stephenplusplus
Copy link
Contributor Author

Could you fix the docs in this PR as well?

The readme and jsdoc for runQuery are updated. Did I miss anything?

This comment was marked as spam.

This comment was marked as spam.

@rakyll
Copy link
Contributor

rakyll commented Aug 1, 2014

The readme and jsdoc for runQuery are updated. Did I miss anything?

Sorry, I've missed them while browsing on a mobile device.

rakyll pushed a commit that referenced this pull request Aug 1, 2014
fixes #38 return key/prop combined object.
@rakyll rakyll merged commit 771d3cc into googleapis:master Aug 1, 2014
@rakyll
Copy link
Contributor

rakyll commented Aug 1, 2014

Thanks :)

silvolu added a commit to silvolu/gcloud-node that referenced this pull request Aug 1, 2014
silvolu added a commit to silvolu/gcloud-node that referenced this pull request Aug 1, 2014
chingor13 pushed a commit that referenced this pull request Sep 12, 2022
chingor13 pushed a commit that referenced this pull request Sep 14, 2022
sofisl pushed a commit that referenced this pull request Sep 16, 2022
sofisl pushed a commit that referenced this pull request Sep 27, 2022
sofisl pushed a commit that referenced this pull request Oct 5, 2022
sofisl pushed a commit that referenced this pull request Oct 8, 2022
sofisl pushed a commit that referenced this pull request Oct 11, 2022
GautamSharda pushed a commit that referenced this pull request Feb 2, 2026
* chore: lock files maintenance

* chore: lock files maintenance
GautamSharda pushed a commit that referenced this pull request Feb 3, 2026
* chore: lock files maintenance

* chore: lock files maintenance
GautamSharda pushed a commit that referenced this pull request Feb 5, 2026
Previously the output of subprocesses would only be printed if
`DEBUG` was set to `true` in the `test-install.ts` file.  This
is not helpful for tests that fail on CI.

Now if tests pass then no process output is printed to the
console.  This makes it easy to see that the tests pass.

However, if a test fails, the output of processes invoked in that
test are automatically printed to the console to help determine
the cause of the error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants