Skip to content

storage: Don't provide multiple methods for file writing#70

Merged
silvolu merged 4 commits intogoogleapis:masterfrom
rakyll:writeinterfaces
Jul 31, 2014
Merged

storage: Don't provide multiple methods for file writing#70
silvolu merged 4 commits intogoogleapis:masterfrom
rakyll:writeinterfaces

Conversation

@rakyll
Copy link
Contributor

@rakyll rakyll commented Jul 31, 2014

This is a proposal, don't merge if you don't like it.

@silvolu
Copy link
Contributor

silvolu commented Jul 31, 2014

We might want to keep the option to upload a file by passing the path to the file, for the 'I just want to upload this file' scenario. What do you think?

@rakyll
Copy link
Contributor Author

rakyll commented Jul 31, 2014

Should we call it bucket.writeFile or provide a filename option?

bucket.write(name, { filename: '/path/to/whatever' }, callback);

@silvolu
Copy link
Contributor

silvolu commented Jul 31, 2014

I like the idea of having only one method, so filename option sounds good!

@rakyll
Copy link
Contributor Author

rakyll commented Jul 31, 2014

Done, PTAL.

@silvolu
Copy link
Contributor

silvolu commented Jul 31, 2014

LGTM

silvolu added a commit that referenced this pull request Jul 31, 2014
@silvolu
Merge pull request #70 from rakyll/writeinterfaces
6cd5692 
storage: Don't provide multiple methods for file writing
@silvolu silvolu merged commit 6cd5692 into googleapis:master Jul 31, 2014
@snyk-bot snyk-bot mentioned this pull request Jan 29, 2022
Open
@mikolajroszak mikolajroszak mentioned this pull request May 7, 2022
Open
@sofisl sofisl mentioned this pull request Sep 16, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 16, 2022
@JustinBeckwith @alexander-fenster
Retry npm install in CI (#70)
932fc1f
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@JustinBeckwith @alexander-fenster
Retry npm install in CI (#70)
4e627d4
This was referenced Oct 5, 2022
Closed
Closed
sofisl pushed a commit that referenced this pull request Oct 8, 2022
@JustinBeckwith @alexander-fenster
Retry npm install in CI (#70)
2b3001c
@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@renovate @JustinBeckwith
chore(deps): lock file maintenance (#70)
6e36989
@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 12, 2022
@renovate @jkwlui
chore(deps): update dependency eslint-config-prettier to v3 (#70)
bdc2af5
This was referenced Oct 12, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@renovate-bot
chore(deps): update dependency eslint-plugin-node to v11 (#70)
d64be2e
@sofisl sofisl mentioned this pull request Oct 13, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@yoshi-automation
chore: update proto namespaces (#70)
e7970e0
@sofisl sofisl mentioned this pull request Oct 13, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@yoshi-automation
chore: clean up Node.js TOC for cloud-rad (#70)
f42e0b6 
* chore: clean up Node.js TOC for cloud-rad

Source-Author: F. Hinkelmann <franziska.hinkelmann@gmail.com>
Source-Date: Wed Oct 21 09:26:04 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: f96d3b455fe27c3dc7bc37c3c9cd27b1c6d269c8
Source-Link: googleapis/synthtool@f96d3b4

* chore: fix Node.js TOC for cloud-rad

Source-Author: F. Hinkelmann <franziska.hinkelmann@gmail.com>
Source-Date: Wed Oct 21 12:01:24 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 901ddd44e9ef7887ee681b9183bbdea99437fdcc
Source-Link: googleapis/synthtool@901ddd4
@sofisl sofisl mentioned this pull request Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 10, 2023
@JustinBeckwith
feat: add synth script and regenerate (#70)
613c469
sofisl pushed a commit that referenced this pull request Jan 24, 2023
@alexander-fenster @callmehiphop
chore: lock files maintenance (#70)
aff8ba4 
* chore: lock files maintenance

* chore: lock files maintenance
sofisl pushed a commit that referenced this pull request Jan 25, 2023
@alexander-fenster @callmehiphop
chore: lock files maintenance (#70)
24f0310 
* chore: lock files maintenance

* chore: lock files maintenance
sofisl pushed a commit that referenced this pull request Jan 26, 2023
@telpirion
feat: adds v1 version of library (#70)
cdd198d 
* feat: adds v1 version of library
* fix: workaround for test failures (added run.ts file)
@sofisl sofisl mentioned this pull request Jan 26, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Sep 14, 2023
@renovate @JustinBeckwith
chore(deps): lock file maintenance (#70)
14f3910
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025
@jmuk
Update gax-nodejs version to 0.10.0 (#70)
c605670 
This includes the refinement of page streaming
miguelvelezsa pushed a commit that referenced this pull request Sep 17, 2025
@renovate-bot
chore(deps): update dependency typescript to ~3.8.0 (#70)
58ca0bf
miguelvelezsa pushed a commit that referenced this pull request Jan 14, 2026
@JustinBeckwith
chore(package): upgrade gts and typescript (#70)
4983114
This was referenced Jan 14, 2026
Closed
Closed
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
@greenkeeper @jinwoo
chore(package): update js-green-licenses to version 0.5.0 (#70)
cae92d9
GautamSharda pushed a commit that referenced this pull request Jan 15, 2026
@greenkeeper @jinwoo
chore(package): update js-green-licenses to version 0.5.0 (#70)
59d5d6a
@GautamSharda GautamSharda mentioned this pull request Jan 20, 2026
Closed
4 tasks
miguelvelezsa pushed a commit that referenced this pull request Jan 21, 2026
@JustinBeckwith
chore(package): upgrade gts and typescript (#70)
eff2788
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 21, 2026
Closed
sofisl pushed a commit that referenced this pull request Jan 27, 2026
@nolanmar511 @aalexand
fix: fix ESOCKETTIMEDOUT Error by increasing timeout to 1 hour for cr…
728028a 
…eateProfile() (#76)

Fixes #70

I tested by running 8 copies of the acmeAir app both before and after this change (for about 10 minutes). Before, ESOCKETTIMEDOUT errors occurred on every request to createProfile(), after, no ESOCKETTIMEDOUT errors were observed.
sofisl pushed a commit that referenced this pull request Jan 27, 2026
@nolanmar511 @aalexand
fix: fix ESOCKETTIMEDOUT Error by increasing timeout to 1 hour for cr…
59cae81 
…eateProfile() (#76)

Fixes #70

I tested by running 8 copies of the acmeAir app both before and after this change (for about 10 minutes). Before, ESOCKETTIMEDOUT errors occurred on every request to createProfile(), after, no ESOCKETTIMEDOUT errors were observed.
miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026
@jmdobry @alexander-fenster
Upgrade repo-tools and regenerate scaffolding. (#70)
f7c60d9 
* Upgrade repo-tools and regenerate scaffolding.

* looks like new package-lock.json fixes lint error

* update package-lock.json for samples
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 28, 2026
Closed
sofisl pushed a commit that referenced this pull request Feb 4, 2026
@JustinBeckwith
chore(package): upgrade gts and typescript (#70)
1b81bc2
This was referenced Feb 4, 2026
Closed
Closed
Merged
Open
sofisl pushed a commit that referenced this pull request Feb 5, 2026
@jmdobry @alexander-fenster
Upgrade repo-tools and regenerate scaffolding. (#70)
c74bf16 
* Upgrade repo-tools and regenerate scaffolding.

* looks like new package-lock.json fixes lint error

* update package-lock.json for samples
GautamSharda pushed a commit that referenced this pull request Feb 5, 2026
@greenkeeper @jinwoo
chore(package): update js-green-licenses to version 0.5.0 (#70)
cffc826
@GautamSharda GautamSharda mentioned this pull request Feb 5, 2026
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rakyll @silvolu