global: remove socket limit - fixes #522#528
Merged
ryanseys merged 1 commit intogoogleapis:masterfrom May 5, 2015
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
|
I can't think of any way to test that's easy, other than writing a unit test to make sure the proper defaults are set on the request object. I feel we should just trust the |
Contributor
Author
|
Aye. |
stephenplusplus
force-pushed
the
spp--global-remove-socket-limit
branch
from
5e28aa9 to
4188eb3
Compare
Contributor
Author
|
Fixed and added tests. No more 666! 🎉 Also, please see my typo correction from the initial post. That was probably weird. |
Contributor
|
Just datastore and storage get these defaults? Or am I reading something wrong here? Should it be added to every API? |
Contributor
Author
|
Most importantly, it's added to common/util, which is where non-fancy API requests all go through (the makeAuthorizedRequest flow). Everywhere you see |
Contributor
|
Perfect! Definitely glossed over that. 💎 |
ryanseys
added a commit
that referenced
this pull request
May 5, 2015
…t-limit global: remove socket limit - fixes #522
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/13e8b547-7af0-436b-b85e-2c1942f8f36a/targets Source-Link: googleapis/synthtool@be74d3e
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 15, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
sofisl
pushed a commit
that referenced
this pull request
Sep 15, 2022
* docs(samples): add example tags to generated samples PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: googleapis/googleapis-gen@eb888bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/74eabfaf-a964-4a5b-b26c-c28d4ae22df0/targets Source-Link: googleapis/synthtool@be74d3e
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
* samples: updates face and person to v1 * 🦉 Updates from OwlBot * fix: docs link issues * fix: appeasethe doc checker * fix: revert READMEs * 🦉 Updates from OwlBot Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 8, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
This was referenced Oct 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
Regenerated the library using [gapic-generator-typescript](https://github.com/googleapis/gapic-generator-typescript) v1.2.1.
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Jan 15, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/13e8b547-7af0-436b-b85e-2c1942f8f36a/targets Source-Link: googleapis/synthtool@be74d3e
GautamSharda
pushed a commit
that referenced
this pull request
Jan 15, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 20, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 21, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
GautamSharda
pushed a commit
that referenced
this pull request
Jan 21, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/13e8b547-7af0-436b-b85e-2c1942f8f36a/targets Source-Link: googleapis/synthtool@be74d3e
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 29, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
GautamSharda
pushed a commit
that referenced
this pull request
Feb 2, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
sofisl
pushed a commit
that referenced
this pull request
Feb 3, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 3, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/13e8b547-7af0-436b-b85e-2c1942f8f36a/targets Source-Link: googleapis/synthtool@be74d3e
4 tasks
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Feb 3, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Feb 4, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
This was referenced Feb 4, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 5, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 5, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/13e8b547-7af0-436b-b85e-2c1942f8f36a/targets Source-Link: googleapis/synthtool@be74d3e
GautamSharda
pushed a commit
that referenced
this pull request
Feb 5, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/13e8b547-7af0-436b-b85e-2c1942f8f36a/targets Source-Link: googleapis/synthtool@be74d3e
GautamSharda
pushed a commit
that referenced
this pull request
Feb 5, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#522
requesthas a defaults option where we can mimic the Node 0.12.0 behavior of not limiting open sockets to 5 at once.@ryanseys - you're
kind_king_ of benching - do you have any tips how I might test that this is working as intended?