Fixed bug in BigQuery's table.import() callback invocation by jwngr · Pull Request #496 · googleapis/google-cloud-node

jwngr · 2015-04-13T19:23:14Z

Fixes #495. Details are provided there.

Google ldap: jwenger

googlebot · 2015-04-13T19:23:16Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

jwngr · 2015-04-13T19:25:57Z

Let me know if I actually need to sign the CLA. I would imagine not since I am a Google employee. My ldap is jwenger.

ryanseys · 2015-04-13T23:15:50Z

Probably should anyway just to shut up the Google bot. I know you're already under NDA. It will follow you around every repo you contribute to.

ryanseys · 2015-04-13T23:17:48Z

LGTM.

Fixed bug in BigQuery's table.import() callback invocation

Fixes googleapis/synthtool#1103 Source-Link: googleapis/synthtool@c3e41da Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:e37a815333a6f3e14d8532efe90cba8aa0d34210f8c0fdbdd9e6a34dcbe51e96

🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.4](https://www.github.com/googleapis/nodejs-redis/compare/v2.2.3...v2.2.4) (2021-07-12) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#496](https://www.github.com/googleapis/nodejs-redis/issues/496)) ([479b07a](https://www.github.com/googleapis/nodejs-redis/commit/479b07aa9bbbbc154a54999706b0699e90e1fe9c)) * **deps:** google-gax v2.17.1 ([#499](https://www.github.com/googleapis/nodejs-redis/issues/499)) ([61d5d83](https://www.github.com/googleapis/nodejs-redis/commit/61d5d8348ba0403147af65975386325273f974eb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore: relocate owl bot post processor * chore: relocate owl bot post processor

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/sinon](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^9.0.0` -> `^10.0.0`](https://renovatebot.com/diffs/npm/@types%2fsinon/9.0.11/10.0.0) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fsinon/10.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fsinon/10.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fsinon/10.0.0/compatibility-slim/9.0.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fsinon/10.0.0/confidence-slim/9.0.11)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-text-to-speech).

🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.5](https://www.github.com/googleapis/nodejs-iot/compare/v2.3.4...v2.3.5) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#496](https://www.github.com/googleapis/nodejs-iot/issues/496)) ([dc278eb](https://www.github.com/googleapis/nodejs-iot/commit/dc278eb4d8ce23454a582fda121766fa0f47e619)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#499](https://www.github.com/googleapis/nodejs-iot/issues/499)) ([0e5967f](https://www.github.com/googleapis/nodejs-iot/commit/0e5967f873ff7db59f400ac651f2b0590650e42f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/057c08c0-647a-4c05-9b44-46e745121a61/targets - [ ] To automatically regenerate this PR, check this box.

Fixes googleapis/synthtool#1103 Source-Link: googleapis/synthtool@c3e41da Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:e37a815333a6f3e14d8532efe90cba8aa0d34210f8c0fdbdd9e6a34dcbe51e96

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

jwngr added 2 commits April 13, 2015 12:10

Fixed bug in BigQuery's table.import() callback invocation

90e3175

Added test for table.import() callback invocation

285415e

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 13, 2015

ryanseys added a commit that referenced this pull request Apr 13, 2015

Merge pull request #496 from jwngr/jw-table-import-bug

0779b27

Fixed bug in BigQuery's table.import() callback invocation

ryanseys merged commit 0779b27 into googleapis:master Apr 13, 2015

jwngr deleted the jw-table-import-bug branch April 15, 2015 20:53

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 15, 2022

fix(deps): google-gax v2.17.0 with mTLS (#496)

535f577

release-please bot mentioned this pull request Sep 15, 2022

chore: release main #3352

Merged

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

chore: add api_shortname and library_type to repo metadata (#496)

db70735

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore: add api_shortname and library_type to repo metadata (#496)

89104ea

sofisl mentioned this pull request Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore: add api_shortname and library_type to repo metadata (#496)

7a82578

sofisl mentioned this pull request Oct 8, 2022

migrate code from googleapis/nodejs-os-login #3389

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 8, 2022

chore: add api_shortname and library_type to repo metadata (#496)

8d10588

This was referenced Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

migrate code from googleapis/nodejs-bigquery-data-transfer #3399

Merged

sofisl pushed a commit that referenced this pull request Oct 12, 2022

chore: relocate owl bot post processor (#496)

ac595cf

* chore: relocate owl bot post processor * chore: relocate owl bot post processor

sofisl pushed a commit that referenced this pull request Oct 13, 2022

chore: relocate owl bot post processor (#496)

77751cc

* chore: relocate owl bot post processor * chore: relocate owl bot post processor

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-text-to-speech #3528

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(deps): google-gax v2.17.1 (#496)

abfefa4

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-asset #3567

Merged

migrate code from googleapis/nodejs-kms #3601

Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(build): migrate to main branch (#496)

bf7ee32

sofisl mentioned this pull request Nov 18, 2022

migrate code from googleapis/nodejs-security-center #3669

Merged

4 tasks

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 17, 2023

docs: add batch samples to README files (#496)

c6dcd00

sofisl pushed a commit that referenced this pull request Jan 24, 2023

refactor: use explicit mocha imports (#496)

cd839c8

sofisl pushed a commit that referenced this pull request Jan 25, 2023

refactor: use explicit mocha imports (#496)

532397a

sofisl pushed a commit that referenced this pull request Sep 14, 2023

build: add generated samples to .eslintignore (#496)

9ed25af

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025

chore(deps): update dependency fs-extra to v8 (#496)

a6b5651

GautamSharda mentioned this pull request Jan 21, 2026

chore: migrate code from googleapis/nodejs-logging-winston #7024

Closed

4 tasks

miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026

fix!: keyToLegacyUrlsafe is now an async method (#496)

94b7b57

miguelvelezsa mentioned this pull request Jan 28, 2026

migrate code from googleapis/nodejs-datastore #7053

Closed

GautamSharda mentioned this pull request Feb 2, 2026

migrate code from googleapis/nodejs-logging-winston #7082

Closed

sofisl pushed a commit that referenced this pull request Feb 3, 2026

test: set minCreationTime for getJobs (#496)

11ef0b8

sofisl mentioned this pull request Feb 3, 2026

migrate code from googleapis/nodejs-bigquery #7111

Merged

4 tasks

GautamSharda mentioned this pull request Feb 3, 2026

migrate code from googleapis/nodejs-logging-winston #7129

Merged

4 tasks

sofisl mentioned this pull request Feb 5, 2026

migrate code from googleapis/nodejs-datastore #7148

Open

4 tasks

sofisl pushed a commit that referenced this pull request Feb 5, 2026

fix!: keyToLegacyUrlsafe is now an async method (#496)

65f94e0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed bug in BigQuery's table.import() callback invocation#496

Fixed bug in BigQuery's table.import() callback invocation#496
ryanseys merged 2 commits intogoogleapis:masterfrom
jwngr:jw-table-import-bug

jwngr commented Apr 13, 2015

Uh oh!

googlebot commented Apr 13, 2015

Uh oh!

jwngr commented Apr 13, 2015

Uh oh!

ryanseys commented Apr 13, 2015

Uh oh!

ryanseys commented Apr 13, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jwngr commented Apr 13, 2015

Uh oh!

googlebot commented Apr 13, 2015

Uh oh!

jwngr commented Apr 13, 2015

Uh oh!

ryanseys commented Apr 13, 2015

Uh oh!

ryanseys commented Apr 13, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants