Storage: add https support to getSignedUrl by mziccard · Pull Request #490 · googleapis/google-cloud-node

mziccard · 2015-04-09T19:50:33Z

Added https field to getSignedUrl options parameter.
If https is set the returned url uses HTTPS.
Otherwise we stick to HTTP.

ryanseys · 2015-04-09T20:50:23Z

You'll have to lint your changes to ensure they meet the requirements. In this case it appears you missed a semi-colon.

Regarding this PR, I'm wondering why we don't just use HTTPS by default. Thoughts @stephenplusplus ?

stephenplusplus · 2015-04-13T13:20:39Z

Always https sounds good to me 👍

mziccard · 2015-04-13T19:33:09Z

Sounds perfect to me.

ryanseys · 2015-04-13T23:21:14Z

@mziccard Would you mind updating this PR to just use https always? :)

mziccard · 2015-04-14T11:12:07Z

In the end, we just added an 's' :)

stephenplusplus · 2015-04-14T16:59:09Z

Merged via 3ce39f6.

Thanks, @mziccard!

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^10.0.0` -> `^11.0.0`](https://renovatebot.com/diffs/npm/sinon/10.0.0/11.1.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/11.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/11.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/11.1.0/compatibility-slim/10.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/11.1.0/confidence-slim/10.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v11.1.0`](https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#1110--2021-05-25) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v11.0.0...31be9a5d5a4762ef01cb195f29024616dfee9ce8) \================== - Add sinon.promise() implementation ([#2369](https://togithub.com/sinonjs/sinon/issues/2369)) - Set wrappedMethod on getters/setters ([#2378](https://togithub.com/sinonjs/sinon/issues/2378)) - \[Docs] Update fake-server usage & descriptions ([#2365](https://togithub.com/sinonjs/sinon/issues/2365)) - Fake docs improvement ([#2360](https://togithub.com/sinonjs/sinon/issues/2360)) - Update nise to 5.1.0 (fixed [#2318](https://togithub.com/sinonjs/sinon/issues/2318)) ### [`v11.0.0`](https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#1100--2021-05-24) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v10.0.1...v11.0.0) \================== - Explicitly use samsam 6.0.2 with fix for [#2345](https://togithub.com/sinonjs/sinon/issues/2345) - Update most packages ([#2371](https://togithub.com/sinonjs/sinon/issues/2371)) - Update compatibility docs ([#2366](https://togithub.com/sinonjs/sinon/issues/2366)) - Update packages (includes breaking fake-timers change, see [#2352](https://togithub.com/sinonjs/sinon/issues/2352)) - Warn of potential memory leaks ([#2357](https://togithub.com/sinonjs/sinon/issues/2357)) - Fix clock test errors ### [`v10.0.1`](https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#1001--2021-04-08) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v10.0.0...v10.0.1) \================== - Upgrade sinon components (bumps y18n to 4.0.1) - Bump y18n from 4.0.0 to 4.0.1 </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-asset).

@miraleung

... chore: update gapic-generator-ruby to the latest commit chore: release gapic-generator-typescript 1.5.0 Committer: @miraleung PiperOrigin-RevId: 380641501 Source-Link: googleapis/googleapis@076f7e9 Source-Link: googleapis/googleapis-gen@27e4c88

🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.3](https://www.github.com/googleapis/nodejs-redis/compare/v2.2.2...v2.2.3) (2021-06-22) ### Bug Fixes * make request optional in all cases ([#490](https://www.github.com/googleapis/nodejs-redis/issues/490)) ([c69e88a](https://www.github.com/googleapis/nodejs-redis/commit/c69e88a51d11c9e0eb66f2e8c0fcd26d1e0ae89a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/0d0efc4e-9ccd-472b-a303-4bbf020fc2e0/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@ba9918c

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/1c7a19e0-0642-4da9-a86e-676ae8965b89/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5451633

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [nock](https://togithub.com/nock/nock) | devDependencies | major | [`^12.0.0` -> `^13.0.0`](https://renovatebot.com/diffs/npm/nock/12.0.3/13.0.0) | --- ### Release Notes <details> <summary>nock/nock</summary> ### [`v13.0.0`](https://togithub.com/nock/nock/releases/v13.0.0) [Compare Source](https://togithub.com/nock/nock/compare/v12.0.3...v13.0.0) See the [Migration Guide](https://togithub.com/nock/nock/blob/75507727cf09a0b7bf0aa7ebdf3621952921b82e/migration_guides/migrating_to_13.md) ##### Breaking changes 1. `Scope.log` has been removed. Use the `debug` library when [debugging](https://togithub.com/nock/nock#debugging) failed matches. 2. `socketDelay` has been removed. Use [`delayConnection`](https://togithub.com/nock/nock#delay-the-connection) instead. 3. `delay`, `delayConnection`, and `delayBody` are now setters instead of additive. 4. [When recording](https://togithub.com/nock/nock#recording), skipping body matching using `*` is no longer supported by `nock.define`. Set the definition body to `undefined` instead. 5. `ClientRequest.abort()` has been updated to align with Node's native behavior. This could be considered a feature, however, it created some subtle differences that are not backwards compatible. Refer to the migration guide for details. 6. Playback of a mocked responses will now never happen until the 'socket' event is emitted. </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-error-reporting).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/1c7a19e0-0642-4da9-a86e-676ae8965b89/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5451633

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [nock](https://togithub.com/nock/nock) | devDependencies | major | [`^12.0.0` -> `^13.0.0`](https://renovatebot.com/diffs/npm/nock/12.0.3/13.0.0) | --- ### Release Notes <details> <summary>nock/nock</summary> ### [`v13.0.0`](https://togithub.com/nock/nock/releases/v13.0.0) [Compare Source](https://togithub.com/nock/nock/compare/v12.0.3...v13.0.0) See the [Migration Guide](https://togithub.com/nock/nock/blob/75507727cf09a0b7bf0aa7ebdf3621952921b82e/migration_guides/migrating_to_13.md) ##### Breaking changes 1. `Scope.log` has been removed. Use the `debug` library when [debugging](https://togithub.com/nock/nock#debugging) failed matches. 2. `socketDelay` has been removed. Use [`delayConnection`](https://togithub.com/nock/nock#delay-the-connection) instead. 3. `delay`, `delayConnection`, and `delayBody` are now setters instead of additive. 4. [When recording](https://togithub.com/nock/nock#recording), skipping body matching using `*` is no longer supported by `nock.define`. Set the definition body to `undefined` instead. 5. `ClientRequest.abort()` has been updated to align with Node's native behavior. This could be considered a feature, however, it created some subtle differences that are not backwards compatible. Refer to the migration guide for details. 6. Playback of a mocked responses will now never happen until the 'socket' event is emitted. </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-error-reporting).

mziccard added 2 commits April 9, 2015 21:20

Add https support to getSignedUrl function

8b40c6f

Update CONTRIBUTORS

9a771a4

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2015

Fixed missing semicolon

b6b8f5a

getSignedUrl always uses https

f455cce

stephenplusplus closed this Apr 14, 2015

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

release-please bot mentioned this pull request Sep 15, 2022

chore: release main #3352

Merged

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

chore: fix the wrong post processor image (#490)

a33436c

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore: fix the wrong post processor image (#490)

51dfafc

sofisl mentioned this pull request Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore: fix the wrong post processor image (#490)

b1dbada

sofisl mentioned this pull request Oct 8, 2022

migrate code from googleapis/nodejs-os-login #3389

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 8, 2022

chore: fix the wrong post processor image (#490)

0fcc1e9

This was referenced Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

migrate code from googleapis/nodejs-language #3395

Merged

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 17, 2023

chore: release 1.7.2 (#490)

a51df11

sofisl pushed a commit that referenced this pull request Jan 24, 2023

fix: increase timeout from 20s to 60s (#490)

0b20dfa

sofisl pushed a commit that referenced this pull request Jan 25, 2023

fix: increase timeout from 20s to 60s (#490)

e5aa27a

miguelvelezsa mentioned this pull request Jan 14, 2026

migrate code from googleapis/nodejs-logging-bunyan #6991

Closed

miguelvelezsa mentioned this pull request Jan 14, 2026

migrate code from googleapis/nodejs-logging-bunyan #6995

Closed

GautamSharda pushed a commit that referenced this pull request Jan 14, 2026

chore: remove duplicate mocha config (#490)

1c05224

GautamSharda pushed a commit that referenced this pull request Jan 20, 2026

chore: remove duplicate mocha config (#490)

36e63ba

GautamSharda mentioned this pull request Jan 20, 2026

chore: migrate code from googleapis/nodejs-error-reporting #7019

Closed

4 tasks

miguelvelezsa mentioned this pull request Jan 21, 2026

migrate code from googleapis/nodejs-logging-bunyan #7021

Closed

GautamSharda pushed a commit that referenced this pull request Jan 21, 2026

chore: remove duplicate mocha config (#490)

440b0aa

GautamSharda mentioned this pull request Jan 21, 2026

chore: migrate code from googleapis/nodejs-logging-winston #7024

Closed

4 tasks

miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026

update .nycrc ignore rules (#490)

ee062e5

miguelvelezsa mentioned this pull request Jan 28, 2026

migrate code from googleapis/nodejs-datastore #7053

Closed

GautamSharda pushed a commit that referenced this pull request Feb 2, 2026

chore: remove duplicate mocha config (#490)

50c56f7

This was referenced Feb 2, 2026

migrate code from googleapis/nodejs-logging-winston #7082

Closed

migrate code from googleapis/nodejs-logging-winston #7129

Merged

GautamSharda pushed a commit that referenced this pull request Feb 3, 2026

chore: remove duplicate mocha config (#490)

6530288

sofisl mentioned this pull request Feb 4, 2026

migrate code from googleapis/nodejs-logging-bunyan #7136

Closed

4 tasks

This was referenced Feb 4, 2026

migrate code from googleapis/nodejs-logging-bunyan #7137

Closed

migrate code from googleapis/nodejs-logging-bunyan #7138

Merged

migrate code from googleapis/nodejs-datastore #7148

Open

sofisl pushed a commit that referenced this pull request Feb 5, 2026

update .nycrc ignore rules (#490)

37230d6

GautamSharda mentioned this pull request Feb 5, 2026

migrate code from googleapis/nodejs-error-reporting #7169

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Storage: add https support to getSignedUrl#490

Storage: add https support to getSignedUrl#490
mziccard wants to merge 4 commits intogoogleapis:masterfrom
mziccard:https-signedurl

mziccard commented Apr 9, 2015

Uh oh!

ryanseys commented Apr 9, 2015

Uh oh!

stephenplusplus commented Apr 13, 2015

Uh oh!

mziccard commented Apr 13, 2015

Uh oh!

ryanseys commented Apr 13, 2015

Uh oh!

mziccard commented Apr 14, 2015

Uh oh!

stephenplusplus commented Apr 14, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mziccard commented Apr 9, 2015

Uh oh!

ryanseys commented Apr 9, 2015

Uh oh!

stephenplusplus commented Apr 13, 2015

Uh oh!

mziccard commented Apr 13, 2015

Uh oh!

ryanseys commented Apr 13, 2015

Uh oh!

mziccard commented Apr 14, 2015

Uh oh!

stephenplusplus commented Apr 14, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants