Use pubsub v1beta2#433
Merged
stephenplusplus merged 2 commits intogoogleapis:masterfrom Mar 10, 2015
ryanseys:pubsub-v1beta2
Merged
Use pubsub v1beta2#433stephenplusplus merged 2 commits intogoogleapis:masterfrom ryanseys:pubsub-v1beta2
stephenplusplus merged 2 commits intogoogleapis:masterfrom
ryanseys:pubsub-v1beta2
Conversation
googlebot
added
the
cla: yes
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
👍 |
lib/pubsub/subscription.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
It looks great! I left non-issue comments on formatting and phrasing, but after settling those, we're both driving straight to big green button city. |
Contributor
Author
|
PTAL at the latest diff in this PR for my fixes. |
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [3.12.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.11.0...v3.12.0) (2021-02-09) ### Features * **samples:** add samples for analyzeIamPolicy and analyzeIamPolicyLongrunning ([#433](https://www.github.com/googleapis/nodejs-asset/issues/433)) ([dfbd75c](https://www.github.com/googleapis/nodejs-asset/commit/dfbd75c98f2977d3a9af06e7637c005b82eda973)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 15, 2022
…ncy versions (#433) Source-Author: Megan Potter <57276408+feywind@users.noreply.github.com> Source-Date: Fri Sep 11 18:47:00 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: fdd03c161003ab97657cc0218f25c82c89ddf4b6 Source-Link: googleapis/synthtool@fdd03c1
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
Update npm scripts: add clean, prelint, prefix; make sure that lint and fix are set properly. Use post-process feature of synthtool.
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 9, 2022
Update npm scripts: add clean, prelint, prefix; make sure that lint and fix are set properly. Use post-process feature of synthtool.
This was referenced Nov 9, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
GautamSharda
pushed a commit
that referenced
this pull request
Jan 21, 2026
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
sofisl
pushed a commit
that referenced
this pull request
Jan 28, 2026
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
This was referenced Jan 29, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Feb 2, 2026
4 tasks
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Feb 3, 2026
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates PubSub to
v1beta2. Some of the parameters for calls have changed to match the API in hopes that it more understandable.I've also made a couple changes that are irrespective of the change in API:
Subscription#setAckDeadlineto set the deadline for a message. I've added respective unit and regression tests in this PR.Note: We have still left out PushConfig various usage and endpoints from this API.
Fixes #414