storage: support file.compose - fixes #401 by stephenplusplus · Pull Request #408 · googleapis/google-cloud-node

stephenplusplus · 2015-02-23T18:41:04Z

Fixes: #401
Refs: #375

var 2013logs = bucket.file('2013-logs.txt');
var 2014logs = bucket.file('2014-logs.txt');

var allLogs = bucket.file('all-logs.txt');

bucket.combine([
  2013logs,
  2014logs
], allLogs, function(err, newFile) {
  // newFile === allLogs
});

lib/common/util.js

ryanseys · 2015-02-24T04:04:53Z

This function is very trigger happy when it comes to throwing which is fine I think, in fact, I can think of a couple more scenarios where it may like to throw:

When destination is given as a File but it's for a different bucket. And when sources come from a different bucket then the one being called on... but I'm not 100% sure we need to worry about that, we can always just default to the bucket the method is called on. Just becomes awkward when that file doesn't exist in that bucket or they think they can do cross-bucket composition.

stephenplusplus · 2015-02-24T13:14:34Z

This function is very trigger happy when it comes to throwing

Only throws in situations where we don't have the minimum required data to let the API call have a chance to succeed.

When destination is given as a File but it's for a different bucket.
And when sources come from a different bucket then the one being called on.

Yeah, I thought of this as well, but avoided as I think the API error should be helpful in that regard. Can implement though if anyone thinks it's important.

ryanseys · 2015-02-24T15:04:05Z

I agree, delegate to the API here.

storage: support file.compose - fixes #401

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/8b7e3986-c966-4325-9ced-bdd850176095/targets - [ ] To automatically regenerate this PR, check this box.

🤖 I have created a release \*beep\* \*boop\* --- ## [3.2.0](https://www.github.com/googleapis/nodejs-os-login/compare/v3.1.3...v3.2.0) (2021-01-09) ### Features * adds style enumeration ([#408](https://www.github.com/googleapis/nodejs-os-login/issues/408)) ([b413e00](https://www.github.com/googleapis/nodejs-os-login/commit/b413e004b0d3c686a25ee2068c761f6aeb65d6e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/8b7e3986-c966-4325-9ced-bdd850176095/targets - [ ] To automatically regenerate this PR, check this box.

🤖 I have created a release \*beep\* \*boop\* --- ## [3.2.0](https://www.github.com/googleapis/nodejs-os-login/compare/v3.1.3...v3.2.0) (2021-01-09) ### Features * adds style enumeration ([#408](https://www.github.com/googleapis/nodejs-os-login/issues/408)) ([b413e00](https://www.github.com/googleapis/nodejs-os-login/commit/b413e004b0d3c686a25ee2068c761f6aeb65d6e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/8b7e3986-c966-4325-9ced-bdd850176095/targets - [ ] To automatically regenerate this PR, check this box.

🤖 I have created a release \*beep\* \*boop\* --- ## [3.2.0](https://www.github.com/googleapis/nodejs-os-login/compare/v3.1.3...v3.2.0) (2021-01-09) ### Features * adds style enumeration ([#408](https://www.github.com/googleapis/nodejs-os-login/issues/408)) ([b413e00](https://www.github.com/googleapis/nodejs-os-login/commit/b413e004b0d3c686a25ee2068c761f6aeb65d6e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/8b7e3986-c966-4325-9ced-bdd850176095/targets - [ ] To automatically regenerate this PR, check this box.

🤖 I have created a release \*beep\* \*boop\* --- ## [3.2.0](https://www.github.com/googleapis/nodejs-os-login/compare/v3.1.3...v3.2.0) (2021-01-09) ### Features * adds style enumeration ([#408](https://www.github.com/googleapis/nodejs-os-login/issues/408)) ([b413e00](https://www.github.com/googleapis/nodejs-os-login/commit/b413e004b0d3c686a25ee2068c761f6aeb65d6e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 474338479 Source-Link: googleapis/googleapis@d5d35e0 Source-Link: googleapis/googleapis-gen@efcd3f9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://togithub.com/mochajs/mocha)) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/mocha/7.2.0/8.0.1) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v8.0.1`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#801--2020-06-10) [Compare Source](https://togithub.com/mochajs/mocha/compare/v8.0.0...v8.0.1) The obligatory patch after a major. #### 🐛 Fixes - [#4328](https://togithub.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@boneskull**](https://togithub.com/boneskull)) ### [`v8.0.0`](https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#800--2020-06-10) [Compare Source](https://togithub.com/mochajs/mocha/compare/v7.2.0...v8.0.0) In this major release, Mocha adds the ability to _run tests in parallel_. Better late than never! Please note the **breaking changes** detailed below. Let's welcome [**@giltayar**](https://togithub.com/giltayar) and [**@nicojs**](https://togithub.com/nicojs) to the maintenance team! #### 💥 Breaking Changes - [#4164](https://togithub.com/mochajs/mocha/issues/4164): **Mocha v8.0.0 now requires Node.js v10.0.0 or newer.** Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 ([**@UlisesGascon**](https://togithub.com/UlisesGascon)) - [#4175](https://togithub.com/mochajs/mocha/issues/4175): Having been deprecated with a warning since v7.0.0, **`mocha.opts` is no longer supported** ([**@juergba**](https://togithub.com/juergba)) ✨ **WORKAROUND:** Replace `mocha.opts` with a [configuration file](https://mochajs.org/#configuring-mocha-nodejs). - [#4260](https://togithub.com/mochajs/mocha/issues/4260): Remove `enableTimeout()` (`this.enableTimeout()`) from the context object ([**@craigtaub**](https://togithub.com/craigtaub)) ✨ **WORKAROUND:** Replace usage of `this.enableTimeout(false)` in your tests with `this.timeout(0)`. - [#4315](https://togithub.com/mochajs/mocha/issues/4315): The `spec` option no longer supports a comma-delimited list of files ([**@juergba**](https://togithub.com/juergba)) ✨ **WORKAROUND**: Use an array instead (e.g., `"spec": "foo.js,bar.js"` becomes `"spec": ["foo.js", "bar.js"]`). - [#4309](https://togithub.com/mochajs/mocha/issues/4309): Drop support for Node.js v13.x line, which is now End-of-Life ([**@juergba**](https://togithub.com/juergba)) - [#4282](https://togithub.com/mochajs/mocha/issues/4282): `--forbid-only` will throw an error even if exclusive tests are avoided via `--grep` or other means ([**@arvidOtt**](https://togithub.com/arvidOtt)) - [#4223](https://togithub.com/mochajs/mocha/issues/4223): The context object's `skip()` (`this.skip()`) in a "before all" (`before()`) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites ([**@juergba**](https://togithub.com/juergba)) - [#4178](https://togithub.com/mochajs/mocha/issues/4178): Remove previously soft-deprecated APIs ([**@wnghdcjfe**](https://togithub.com/wnghdcjfe)): - `Mocha.prototype.ignoreLeaks()` - `Mocha.prototype.useColors()` - `Mocha.prototype.useInlineDiffs()` - `Mocha.prototype.hideDiff()` #### 🎉 Enhancements - [#4245](https://togithub.com/mochajs/mocha/issues/4245): Add ability to run tests in parallel for Node.js (see [docs](https://mochajs.org/#parallel-tests)) ([**@boneskull**](https://togithub.com/boneskull)) ❗ See also [#4244](https://togithub.com/mochajs/mocha/issues/4244); [Root Hook Plugins (docs)](https://mochajs.org/#root-hook-plugins) -- _root hooks must be defined via Root Hook Plugins to work in parallel mode_ - [#4304](https://togithub.com/mochajs/mocha/issues/4304): `--require` now works with ES modules ([**@JacobLey**](https://togithub.com/JacobLey)) - [#4299](https://togithub.com/mochajs/mocha/issues/4299): In some circumstances, Mocha can run ES modules under Node.js v10 -- _use at your own risk!_ ([**@giltayar**](https://togithub.com/giltayar)) #### 📖 Documentation - [#4246](https://togithub.com/mochajs/mocha/issues/4246): Add documentation for parallel mode and Root Hook plugins ([**@boneskull**](https://togithub.com/boneskull)) #### 🐛 Fixes (All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above) </details> --- ### Renovate configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-automl).

storage: support file.compose - fixes googleapis#401

2a81d2d

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 23, 2015

stephenplusplus reviewed Feb 23, 2015
View reviewed changes

lib/common/util.js

This comment was marked as spam.

Sign in to view

"\s".replace("")

8308106

ryanseys added a commit that referenced this pull request Feb 24, 2015

Merge pull request #408 from stephenplusplus/spp--storage-combine

19ca624

storage: support file.compose - fixes #401

ryanseys merged commit 19ca624 into googleapis:master Feb 24, 2015

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl mentioned this pull request Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

4 tasks

sofisl mentioned this pull request Oct 8, 2022

migrate code from googleapis/nodejs-os-login #3389

Closed

4 tasks

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

4 tasks

This was referenced Oct 11, 2022

chore: release main #3393

Closed

chore: release main #3394

Closed

sofisl pushed a commit that referenced this pull request Nov 11, 2022

chore: fix api_shortname in repo-metadata (#408)

0962d3f

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

4 tasks

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 17, 2023

build: use config file for linkinator (#408)

65152d2

sofisl pushed a commit that referenced this pull request Jan 24, 2023

chore(deps): update dependency @google-cloud/storage to v3 (#408)

04f6ba5

sofisl pushed a commit that referenced this pull request Jan 25, 2023

chore(deps): update dependency @google-cloud/storage to v3 (#408)

af4c298

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

GautamSharda pushed a commit that referenced this pull request Jan 14, 2026

Error reporting (#408)

3c696d9

GautamSharda pushed a commit that referenced this pull request Jan 14, 2026

chore(deps): update dependency c8 to v6 (#408)

b31f9f8

GautamSharda pushed a commit that referenced this pull request Jan 14, 2026

fix(docs): add jsdoc-region-tag plugin (#408)

f42635b

GautamSharda pushed a commit that referenced this pull request Jan 15, 2026

Error reporting (#408)

40d3f4c

GautamSharda pushed a commit that referenced this pull request Jan 15, 2026

chore(deps): update dependency c8 to v6 (#408)

ee3c945

GautamSharda pushed a commit that referenced this pull request Jan 20, 2026

fix(docs): add jsdoc-region-tag plugin (#408)

169734f

GautamSharda mentioned this pull request Jan 20, 2026

chore: migrate code from googleapis/nodejs-error-reporting #7019

Closed

4 tasks

GautamSharda pushed a commit that referenced this pull request Jan 21, 2026

fix(docs): add jsdoc-region-tag plugin (#408)

fb241f3

GautamSharda mentioned this pull request Jan 21, 2026

chore: migrate code from googleapis/nodejs-logging-winston #7024

Closed

4 tasks

miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026

build: add new kokoro config for coverage and release-please (#408)

25289e6

miguelvelezsa mentioned this pull request Jan 28, 2026

migrate code from googleapis/nodejs-datastore #7053

Closed

GautamSharda pushed a commit that referenced this pull request Feb 2, 2026

fix(docs): add jsdoc-region-tag plugin (#408)

bce36a3

This was referenced Feb 2, 2026

migrate code from googleapis/nodejs-logging-winston #7082

Closed

migrate code from googleapis/nodejs-logging-winston #7129

Merged

GautamSharda pushed a commit that referenced this pull request Feb 3, 2026

fix(docs): add jsdoc-region-tag plugin (#408)

942d511

sofisl mentioned this pull request Feb 5, 2026

migrate code from googleapis/nodejs-datastore #7148

Open

4 tasks

sofisl pushed a commit that referenced this pull request Feb 5, 2026

build: add new kokoro config for coverage and release-please (#408)

e3c1caf

GautamSharda pushed a commit that referenced this pull request Feb 5, 2026

Error reporting (#408)

72988d5

GautamSharda pushed a commit that referenced this pull request Feb 5, 2026

chore(deps): update dependency c8 to v6 (#408)

3d7b678

GautamSharda mentioned this pull request Feb 5, 2026

migrate code from googleapis/nodejs-error-reporting #7169

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage: support file.compose - fixes #401#408

storage: support file.compose - fixes #401#408
ryanseys merged 2 commits intogoogleapis:masterfrom
stephenplusplus:spp--storage-combine

stephenplusplus commented Feb 23, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

ryanseys commented Feb 24, 2015

Uh oh!

stephenplusplus commented Feb 24, 2015

Uh oh!

ryanseys commented Feb 24, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

stephenplusplus commented Feb 23, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

ryanseys commented Feb 24, 2015

Uh oh!

stephenplusplus commented Feb 24, 2015

Uh oh!

ryanseys commented Feb 24, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants