storage: createReadStream: accept start/end offsets#327
Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom Dec 23, 2014
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
force-pushed
the
spp--download-byte-range
branch
from
987ee70 to
7dc9761
Compare
Contributor
|
+1 from me! :) |
Contributor
|
Can we haz a regression test? |
stephenplusplus
force-pushed
the
spp--download-byte-range
branch
from
7dc9761 to
04964bd
Compare
Contributor
Author
|
Yes, that was a good idea! I didn't turn off validation. stephenplusplus@04964bd |
stephenplusplus
force-pushed
the
spp--download-byte-range
branch
2 times, most recently
from
cfe28da to
34c0d76
Compare
Contributor
Author
|
Fixed the bugs I introduced with the last commit (tests weren't updated to match changes I made in this PR). Squashed all the commits into one, ready for final review & merge. |
stephenplusplus
force-pushed
the
spp--download-byte-range
branch
from
34c0d76 to
ba0782e
Compare
Contributor
|
LGTM, @ryanseys ? |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Other than few comments, overall looks good to me. |
stephenplusplus
force-pushed
the
spp--download-byte-range
branch
from
ba0782e to
15c5aa7
Compare
Contributor
Author
Contributor
Author
Contributor
|
@stephenplusplus 0.12.0 sounds good to me |
stephenplusplus
force-pushed
the
spp--download-byte-range
branch
from
15c5aa7 to
cae3cb6
Compare
stephenplusplus
added a commit
that referenced
this pull request
Dec 23, 2014
storage: createReadStream: accept start/end offsets
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
…or (#327) Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 30, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 20, 2026
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 21, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 21, 2026
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Feb 2, 2026
This was referenced Feb 2, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Feb 3, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 4, 2026
This was referenced Feb 4, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Feb 5, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RE: #318
This adds
options.startandoptions.endtofile.createReadStream, using theRangeHTTP header when calling the API.// @janesconference for a review, since it was all his idea 💡 👍